From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id KDklFVxZ2WcAzxMAWB0awg (envelope-from ) for ; Tue, 18 Mar 2025 07:30:36 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=KjMrFz1y; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 5228F1E100; Tue, 18 Mar 2025 07:30:36 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 041A11E0C0 for ; Tue, 18 Mar 2025 07:30:36 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BB6243858415 for ; Tue, 18 Mar 2025 11:30:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BB6243858415 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=KjMrFz1y Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id BB4423858D29 for ; Tue, 18 Mar 2025 11:30:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BB4423858D29 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BB4423858D29 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1742297403; cv=none; b=i6Njt3tkINSS0FIq5c+9X+nuCR4AMFi9c0DK7zah9TLBCe4fH2HCIzGoSROWNEnh/C+iOP0SPmWL49+hKMx7d4e9JfzZqyJyoI3uQnwLbmHbMhtSala5IVbiYLPWp2QB/FlhfRMEQtgioRNbOBpQ+WrNBZP2rSoCIU8lvMLhJyg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1742297403; c=relaxed/simple; bh=Couhk6BN9IvNRzBS1RFAAAXFikGi6zKvn/MamIRAIvg=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=qZTb3lCqBCW8dj76QjY+uAx+TsnBLyddi0hWPVL+7HoIjWg7ymCr67qhdtWuMtUd8ioE/tXBDl+UIqhd5CDFM/sokiOqxvMZ8erGz0fWhuwshvqZz1gTsRk7KyVdUH1GGQkSFfgk3pHr1aLQGT8f4K6sEUCP2grHK71KsGRDkKM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BB4423858D29 Received: from eig-obgw-5008a.ext.cloudfilter.net ([10.0.29.246]) by cmsmtp with ESMTPS id uUpftV8haVkcRuV91tCLo6; Tue, 18 Mar 2025 11:30:03 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id uV8ztbBM39ZRbuV90txu20; Tue, 18 Mar 2025 11:30:02 +0000 X-Authority-Analysis: v=2.4 cv=SL1EVvvH c=1 sm=1 tr=0 ts=67d9593a a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=Vs1iUdzkB0EA:10 a=ItBw4LHWJt0A:10 a=dzWzf_mpAAAA:8 a=pO-Jm7icJMgNt870cDAA:9 a=b4DR9a7p2ZdsqdHBznES:22 a=6Ogn3jAGHLSNbaov7Orx:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=3TXIdB9br8fn7eONfQxhcpkmRC8dCeR7nYvoI7IMhb0=; b=KjMrFz1y4KdZP5a8UcUw1lZQ8M jcyoPHqQRxr1luTZl7dUuXRGdw4eKRCv7wUX97SqpNf5OXtJKaqLsRDTf8jlKHpoKhvIf9OhRdQla 3mY0Z5PKat/iVcShW960tnGgq; Received: from 97-122-123-18.hlrn.qwest.net ([97.122.123.18]:50098 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1tuV8z-00000002m0b-12eq; Tue, 18 Mar 2025 05:30:01 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Use scoped_fd in linux-nat.c:proc_mem_file In-Reply-To: (Simon Marchi's message of "Mon, 17 Mar 2025 22:16:17 -0400") References: <20250317205529.3885971-1-tom@tromey.com> X-Attribution: Tom Date: Tue, 18 Mar 2025 05:29:59 -0600 Message-ID: <87y0x2tw3s.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.123.18 X-Source-L: No X-Exim-ID: 1tuV8z-00000002m0b-12eq X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-123-18.hlrn.qwest.net (prentzel) [97.122.123.18]:50098 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfCDvv9mCVrSWvTMD/s5G/7QgIPBjNld7CpoCMzKy7nRW9IToFmFlzPVpr9jL/8A3/a6DpdPGSRk6q/giRKcwPc2YG8O6kR9t26bD4H0RAqQlb4SJ84nO +4z3Ljf4iQRtiBoY6lqKKtAYxPnX5XCKfXHPtua4Dltf95WmW+U1IkBcOF3rSH1TEVW7TOwLh/m05ZFZimLfjkWxtytutATDM1A= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: >> + proc_mem_file (proc_mem_file &&) = default; >> + proc_mem_file &operator= (proc_mem_file &&) = default; Simon> Is it really needed to add the move constructor / move assignment Simon> operator? In fact, I would think that you could remove the Simon> DISABLE_COPY_AND_ASSIGN, since just having the scoped_fd as a field will Simon> do the right thing. I removed both of these. Tom