Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Fabian Kilger <kilger@sec.in.tum.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 0/2][PR GDB/32956] gdb: fix GDB failing to find build-id debug files in linux mount namespaces
Date: Fri, 30 May 2025 13:50:07 -0600	[thread overview]
Message-ID: <87y0ud280g.fsf@tromey.com> (raw)
In-Reply-To: <20250511150113.3163767-1-kilger@sec.in.tum.de> (Fabian Kilger's message of "Sun, 11 May 2025 17:01:11 +0200")

>>>>> "Fabian" == Fabian Kilger <kilger@sec.in.tum.de> writes:

Fabian> GDB can no longer find build-id debug files in docker containers.
Fabian> The cause is the new algorithm to look for a build-id-based debug file
Fabian> (introduced by commit 22836ca88591ac7efacf06d5b6db191763fd8aba).
Fabian> It makes use of fileio_stat. As fileio_stat is not supported by
Fabian> gdb/nat/linux-namespace.c, all stat calls would be performed on the
Fabian> host and not inside the mount namespace. Furthermore, gdb/build-id.c
Fabian> calls target_fileio_stat with inferior none, thus stat will always be
Fabian> performed on the host mount namespace instead of the target's mount
Fabian> namespace.

Fabian> The patch is split into two parts: First, add support for fileio_stat
Fabian> querying the linux mount namespace and second, adjust gdb/build-id.c
Fabian> to call target_fileio_stat with current_inferior () instead of nullptr.

Fabian> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=32956

Hi, I don't know anything at all about this area, but some keywords in
the thread triggered a memory of this patch:

https://inbox.sourceware.org/gdb-patches/20230321120126.1418012-1-benjamin@sipsolutions.net/

Can you say how it compares and whether your patch fixes that same
problem?

thanks,
Tom

  parent reply	other threads:[~2025-05-30 19:50 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-11 15:01 Fabian Kilger
2025-05-11 15:01 ` [PATCH 1/2][PR GDB/32956] gdb: implement linux namespace support for fileio_stat Fabian Kilger
2025-05-23 18:14   ` Andrew Burgess
2025-05-24 20:25     ` Fabian Kilger
2025-06-11  9:43       ` Andrew Burgess
2025-05-24 10:46   ` Andrew Burgess
2025-05-24 19:43     ` Fabian Kilger
2025-05-24 20:43       ` Fabian Kilger
2025-06-11  9:47         ` Andrew Burgess
2025-06-11  9:58           ` Andrew Burgess
2025-06-11 13:29             ` Tom Tromey
2025-06-11 14:47               ` Andrew Burgess
2025-06-11 17:45                 ` Tom Tromey
2025-06-11 15:06             ` Fabian Kilger
2025-05-11 15:01 ` [PATCH 2/2][PR GDB/32956] gdb: query inferior's filesystem for build-id debug files Fabian Kilger
2025-05-23 18:20   ` Andrew Burgess
2025-05-24 19:54     ` Fabian Kilger
2025-06-10  9:10       ` Andrew Burgess
2025-06-11  8:11         ` Fabian Kilger
2025-06-11  9:35           ` Andrew Burgess
2025-06-11 14:00             ` Simon Marchi
2025-05-30 19:50 ` Tom Tromey [this message]
2025-06-10 17:02   ` [PATCH 0/2][PR GDB/32956] gdb: fix GDB failing to find build-id debug files in linux mount namespaces Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y0ud280g.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=kilger@sec.in.tum.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox