From: Fabian Kilger <kilger@sec.in.tum.de>
To: gdb-patches@sourceware.org
Cc: Fabian Kilger <kilger@sec.in.tum.de>
Subject: [PATCH 2/2][PR GDB/32956] gdb: query inferior's filesystem for build-id debug files
Date: Sun, 11 May 2025 17:01:13 +0200 [thread overview]
Message-ID: <20250511150113.3163767-3-kilger@sec.in.tum.de> (raw)
In-Reply-To: <20250511150113.3163767-1-kilger@sec.in.tum.de>
This fixes a bug related to build-id files with linux namespaces.
Specifically, we expect the debug files to be present inside the container,
thus the container filesystem should be queried if the program is running
inside one.
---
gdb/build-id.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/gdb/build-id.c b/gdb/build-id.c
index 43a80dd3978..abbd65a7c12 100644
--- a/gdb/build-id.c
+++ b/gdb/build-id.c
@@ -29,6 +29,7 @@
#include "gdbsupport/scoped_fd.h"
#include "debuginfod-support.h"
#include "extension.h"
+#include "inferior.h"
/* See build-id.h. */
@@ -128,7 +129,8 @@ build_id_to_debug_bfd_1 (const std::string &original_link,
if (supports_target_stat != TRIBOOL_FALSE)
{
struct stat sb;
- int res = target_fileio_stat (nullptr, link_on_target, &sb,
+ int res = target_fileio_stat (current_inferior (),
+ link_on_target, &sb,
&target_errno);
if (res != 0 && target_errno != FILEIO_ENOSYS)
@@ -157,7 +159,7 @@ build_id_to_debug_bfd_1 (const std::string &original_link,
the path doesn't exist, but we just assume that anything
other than EINVAL indicates the path doesn't exist. */
std::optional<std::string> link_target
- = target_fileio_readlink (nullptr, link_on_target,
+ = target_fileio_readlink (current_inferior (), link_on_target,
&target_errno);
if (link_target.has_value ()
|| target_errno == FILEIO_EINVAL)
--
2.49.0
next prev parent reply other threads:[~2025-05-11 15:02 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-11 15:01 [PATCH 0/2][PR GDB/32956] gdb: fix GDB failing to find build-id debug files in linux mount namespaces Fabian Kilger
2025-05-11 15:01 ` [PATCH 1/2][PR GDB/32956] gdb: implement linux namespace support for fileio_stat Fabian Kilger
2025-05-23 18:14 ` Andrew Burgess
2025-05-24 20:25 ` Fabian Kilger
2025-06-11 9:43 ` Andrew Burgess
2025-05-24 10:46 ` Andrew Burgess
2025-05-24 19:43 ` Fabian Kilger
2025-05-24 20:43 ` Fabian Kilger
2025-06-11 9:47 ` Andrew Burgess
2025-06-11 9:58 ` Andrew Burgess
2025-06-11 13:29 ` Tom Tromey
2025-06-11 14:47 ` Andrew Burgess
2025-06-11 17:45 ` Tom Tromey
2025-06-11 15:06 ` Fabian Kilger
2025-05-11 15:01 ` Fabian Kilger [this message]
2025-05-23 18:20 ` [PATCH 2/2][PR GDB/32956] gdb: query inferior's filesystem for build-id debug files Andrew Burgess
2025-05-24 19:54 ` Fabian Kilger
2025-06-10 9:10 ` Andrew Burgess
2025-06-11 8:11 ` Fabian Kilger
2025-06-11 9:35 ` Andrew Burgess
2025-06-11 14:00 ` Simon Marchi
2025-05-30 19:50 ` [PATCH 0/2][PR GDB/32956] gdb: fix GDB failing to find build-id debug files in linux mount namespaces Tom Tromey
2025-06-10 17:02 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250511150113.3163767-3-kilger@sec.in.tum.de \
--to=kilger@sec.in.tum.de \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox