Re: [PATCH] gdb/python: allow Architecture.disassemble to give styled output

[Tom Tromey <tom@tromey.com>]

>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:

Andrew> Extend the Architecture.disassemble API to allow the user to request
Andrew> styled disassembler output via a new styling argument.  A user can now
Andrew> write:

Andrew>   insn = arch.disassemble(address, styling = True)

Andrew> The instruction strings returned within INSN will contain ANSI escape
Andrew> sequences so long as 'set style enabled on' is in effect.  This means
Andrew> that the user's personal settings (disabling styling) will override a
Andrew> GDB extension that requests styled disassembler output.  I think this
Andrew> makes sense.

Andrew> The default for the styling argument is False, this maintains the
Andrew> current unstyled output as default.

Looks good to me.  Thank you.
Approved-By: Tom Tromey <tom@tromey.com>

Tom