From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id GYrzGbWOvWlRpzEAWB0awg (envelope-from ) for ; Fri, 20 Mar 2026 14:15:17 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=iW/24TOT; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 64ACF1E0BC; Fri, 20 Mar 2026 14:15:17 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id ABC8D1E08C for ; Fri, 20 Mar 2026 14:15:16 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 472324C31882 for ; Fri, 20 Mar 2026 18:15:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 472324C31882 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=iW/24TOT Received: from omta40.uswest2.a.cloudfilter.net (omta40.uswest2.a.cloudfilter.net [35.89.44.39]) by sourceware.org (Postfix) with ESMTPS id 3EC6A4C900C5 for ; Fri, 20 Mar 2026 17:54:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3EC6A4C900C5 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3EC6A4C900C5 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774029300; cv=none; b=SDYSXJ4JCaBVpi/Sqa14hjlg4AF1pe5fdTu72TtTVFP7d/OoSVVak5m2usbzkGHnMlD48PG5uhBSnsq/SkcMMi4UBWDilwwORVvGXLajMrh0xzrllcRwJ3haXqBETsBTpABkukgGAEG9VxLVWcejSuwMK+zGofx6t6+hdpjSAlk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774029300; c=relaxed/simple; bh=p+Cb30CNwjVaPvuEgdGVZMKbfSbFbWKH+zi5ek4ErSg=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=tbcttmqWXm3AZc0OEa8X/HBLTiA1RmRJ0SIDgBUyKbwU3SvjmZYBLgReyknyYqeAmnTRLJ8LGMMeDt6f5u3BhCLrQoYAEagtVXef59OMI0mL/j4B0wcRK8yQapnI4cjl8O73OlidzpLHsq+WFfBE02gvstiKEp7s+M6gQgVPKoA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3EC6A4C900C5 Received: from eig-obgw-6005b.ext.cloudfilter.net ([10.0.30.162]) by cmsmtp with ESMTPS id 3e21wdccjaPqL3e3hwFOo7; Fri, 20 Mar 2026 17:54:53 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 3e3awX5yqHSQM3e3awS5Fj; Fri, 20 Mar 2026 17:54:46 +0000 X-Authority-Analysis: v=2.4 cv=GIQIEvNK c=1 sm=1 tr=0 ts=69bd89ec a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=Yq5XynenixoA:10 a=ItBw4LHWJt0A:10 a=20KFwNOVAAAA:8 a=zstS-IiYAAAA:8 a=Y-oJz_0K8rza3qKiWdIA:9 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ujr4CxqWOqbZiCLI3lqmETH2BuIBZPDeeU2G/AVR2Rk=; b=iW/24TOTHcRD4qL7xTN7Yofitu PuflwAmIlPTWkW4/VKF04FrtmXdtmbwsfwWWjXkgFRM7KpYDbbze795cXdKedmRxxS1H/qAsvk+v0 +CFcCX9NlU0vLUdUibz2Fp5nb; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:43870 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1w3e3Z-00000002WFz-3mHw; Fri, 20 Mar 2026 11:54:45 -0600 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/python: allow Architecture.disassemble to give styled output In-Reply-To: <2412723aff2f39ed778743b957d2ab8da51335e1.1774020654.git.aburgess@redhat.com> (Andrew Burgess's message of "Fri, 20 Mar 2026 15:31:11 +0000") References: <2412723aff2f39ed778743b957d2ab8da51335e1.1774020654.git.aburgess@redhat.com> X-Attribution: Tom Date: Fri, 20 Mar 2026 11:54:44 -0600 Message-ID: <87y0jm8jyz.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1w3e3Z-00000002WFz-3mHw X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:43870 X-Source-Auth: tom+tromey.com X-Email-Count: 10 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfESB3eO2HZBlI3SeaHGNYLh/mZo/T6uh5zivYycRPnXALq5XFLDWaw544wLLNg1hUrMZza7wW/6Nj/ZtSMvVq0cMFRSaQJCKeSa92mr0XUXKjg8RLstb nNxU3kTNDQF3YOxpuEebiKLNfqpJ64oLTm3q6AC5nku6frMWZppV0EwSXHIsvsLv0fRuHl7kL5LE2kL/GdaCYPGsiEP9ID9DyAI= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Andrew" == Andrew Burgess writes: Andrew> Extend the Architecture.disassemble API to allow the user to request Andrew> styled disassembler output via a new styling argument. A user can now Andrew> write: Andrew> insn = arch.disassemble(address, styling = True) Andrew> The instruction strings returned within INSN will contain ANSI escape Andrew> sequences so long as 'set style enabled on' is in effect. This means Andrew> that the user's personal settings (disabling styling) will override a Andrew> GDB extension that requests styled disassembler output. I think this Andrew> makes sense. Andrew> The default for the styling argument is False, this maintains the Andrew> current unstyled output as default. Looks good to me. Thank you. Approved-By: Tom Tromey Tom