From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@efficios.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v4 06/10] gdb/solib-rocm: move per-inferior data to rocm_solib_ops
Date: Fri, 21 Aug 2026 13:19:00 -0600 [thread overview]
Message-ID: <87y0dznuxn.fsf@tromey.com> (raw)
In-Reply-To: <20260807135259.111194-7-simon.marchi@efficios.com> (Simon Marchi's message of "Fri, 7 Aug 2026 09:52:24 -0400")
>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:
Simon> Move the data currently stored in an inferior registry directly into
Simon> rocm_solib_ops. This changes the storage of this data from "per
Simon> inferior" to "per program-space", but it should be equivalent, since
Simon> there is usually a 1:1 mapping between those two. The only time there
Simon> isn't a 1:1 mapping is during a vfork, before the exec/exit, but no ROCm
Simon> activity happens during that slice of time.
I don't really know the rocm code, but this seems fine to me.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
next prev parent reply other threads:[~2026-08-21 19:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-07 13:52 [PATCH v4 00/10] Multiple solib_ops in a program_space Simon Marchi
2026-08-07 13:52 ` [PATCH v4 01/10] gdb/solib-rocm: assert that host ops isn't rocm_solib_ops Simon Marchi
2026-08-07 13:52 ` [PATCH v4 02/10] gdb/solib-rocm: pass reference to cache to rocm_code_object_stream_file Simon Marchi
2026-08-07 13:52 ` [PATCH v4 03/10] gdb/solib-rocm: add cached_target_fd to manage cached fd lifetime Simon Marchi
2026-08-07 13:52 ` [PATCH v4 04/10] gdb: de-constify some methods of solib_ops Simon Marchi
2026-08-07 13:52 ` [PATCH v4 05/10] gdb/solib: add remove_solib function Simon Marchi
2026-08-07 13:52 ` [PATCH v4 06/10] gdb/solib-rocm: move per-inferior data to rocm_solib_ops Simon Marchi
2026-08-21 19:19 ` Tom Tromey [this message]
2026-08-07 13:52 ` [PATCH v4 07/10] gdb/solib-rocm: save inferior in rocm_solib_ops Simon Marchi
2026-08-07 13:52 ` [PATCH v4 08/10] gdb: add objfile -> solib backlink Simon Marchi
2026-08-21 19:24 ` Tom Tromey
2026-08-07 13:52 ` [PATCH v4 09/10] gdb: change default objfile iteration order to start with current objfile Simon Marchi
2026-08-07 13:52 ` [PATCH v4 10/10] gdb: multiple solib_ops per program space Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y0dznuxn.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox