Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@efficios.com>
Cc: gdb-patches@sourceware.org,  Simon Marchi <simon.marchi@polymtl.ca>
Subject: Re: [PATCH v4 08/10] gdb: add objfile -> solib backlink
Date: Fri, 21 Aug 2026 13:24:30 -0600	[thread overview]
Message-ID: <87tsonnuoh.fsf@tromey.com> (raw)
In-Reply-To: <20260807135259.111194-9-simon.marchi@efficios.com> (Simon Marchi's message of "Fri, 7 Aug 2026 09:52:26 -0400")

>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:

Simon> From: Simon Marchi <simon.marchi@polymtl.ca>
Simon> The following "multiple solib_ops" patch will require accessing the
Simon> solib(s) related to an objfile fairly often.  To make that easier, add
Simon> an objfile to solib backlink.

Simon> However, I learned that there may be more than one solib linked to one
Simon> objfile.  The only case I am aware of is the dynamic linker itself
Simon> (ld-linux.so), where the same instance (same load address) appears in
Simon> all namespaces.  We get one solib per "view" of that library, but they
Simon> all point to the same objfile.  So this backlink is actually a vector.

Simon> Rename find_solib_for_objfile to find_one_solib_for_objfile to reflect
Simon> that this function returns just one of possible multiple solibs for the
Simon> given objfile (if that ever matters).  To be clear, this doesn't change
Simon> its behavior, this is what it was doing before this patch.

Looks good, thanks.
Approved-By: Tom Tromey <tom@tromey.com>

Tom

  reply	other threads:[~2026-08-21 19:24 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-07 13:52 [PATCH v4 00/10] Multiple solib_ops in a program_space Simon Marchi
2026-08-07 13:52 ` [PATCH v4 01/10] gdb/solib-rocm: assert that host ops isn't rocm_solib_ops Simon Marchi
2026-08-07 13:52 ` [PATCH v4 02/10] gdb/solib-rocm: pass reference to cache to rocm_code_object_stream_file Simon Marchi
2026-08-07 13:52 ` [PATCH v4 03/10] gdb/solib-rocm: add cached_target_fd to manage cached fd lifetime Simon Marchi
2026-08-07 13:52 ` [PATCH v4 04/10] gdb: de-constify some methods of solib_ops Simon Marchi
2026-08-07 13:52 ` [PATCH v4 05/10] gdb/solib: add remove_solib function Simon Marchi
2026-08-07 13:52 ` [PATCH v4 06/10] gdb/solib-rocm: move per-inferior data to rocm_solib_ops Simon Marchi
2026-08-21 19:19   ` Tom Tromey
2026-08-07 13:52 ` [PATCH v4 07/10] gdb/solib-rocm: save inferior in rocm_solib_ops Simon Marchi
2026-08-07 13:52 ` [PATCH v4 08/10] gdb: add objfile -> solib backlink Simon Marchi
2026-08-21 19:24   ` Tom Tromey [this message]
2026-08-07 13:52 ` [PATCH v4 09/10] gdb: change default objfile iteration order to start with current objfile Simon Marchi
2026-08-07 13:52 ` [PATCH v4 10/10] gdb: multiple solib_ops per program space Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tsonnuoh.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@efficios.com \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox