From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simark@simark.ca>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/4] Change evpy_emit_event to accept a gdbpy_opt_borrowed_ref
Date: Mon, 14 Sep 2026 10:59:57 -0600 [thread overview]
Message-ID: <87y0d36a5u.fsf@tromey.com> (raw)
In-Reply-To: <8c6dadb8-d305-4df8-b5ac-42c15a34b734@simark.ca> (Simon Marchi's message of "Mon, 14 Sep 2026 11:42:47 -0400")
>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
Simon> Unrelated, but those two if could be collapsed into one with &&.
Yeah, I normally don't care about this kind of thing.
Simon> Also unrelated: I would change evregpy_no_listeners_p to
Simon> evregpy_has_listeners_p, because double-negative is confusing.
Simon> I can make following patches to change those.
Alright.
Simon> Copying a review comment from Claude that seems important:
[...]
Yeah. I think there's a longstanding GCC bug about not warning about
this.
Anyway I fixed it.
Simon> Otherwise, it also noted:
Simon> - gdb/python/py-breakpoint.c:1309 and :1340: both calls now fit on one line.
I don't know which lines these are but the obvious-to-me choices end up
at 81/82 characters and so can't be changed.
Tom
next prev parent reply other threads:[~2026-09-14 17:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-08 21:47 [PATCH 0/4] Use gdbpy_borrowed_ref more + cast removal Tom Tromey
2026-08-08 21:47 ` [PATCH 1/4] Change evpy_emit_event to accept a gdbpy_opt_borrowed_ref Tom Tromey
2026-09-14 15:42 ` Simon Marchi
2026-09-14 16:59 ` Tom Tromey [this message]
2026-09-14 19:58 ` Simon Marchi
2026-09-14 17:42 ` Tom Tromey
2026-09-14 18:27 ` Tom Tromey
2026-08-08 21:47 ` [PATCH 2/4] Change evpy_add_attribute to accept gdbpy_borrowed_ref Tom Tromey
2026-08-08 21:47 ` [PATCH 3/4] Use gdbpy_borrowed_ref when creating events Tom Tromey
2026-09-14 15:46 ` Simon Marchi
2026-08-08 21:47 ` [PATCH 4/4] Remove unneeded casts to PyObject* Tom Tromey
2026-09-14 15:48 ` [PATCH 0/4] Use gdbpy_borrowed_ref more + cast removal Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y0d36a5u.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox