From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id qZARKSwoqGpPeQwAWB0awg (envelope-from ) for ; Mon, 14 Sep 2026 13:00:28 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=LFBEznnK; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id A32551E01F; Mon, 14 Sep 2026 13:00:28 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 468B21E01F for ; Mon, 14 Sep 2026 13:00:28 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BECB64BAE7FC for ; Mon, 14 Sep 2026 17:00:27 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BECB64BAE7FC Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=LFBEznnK Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id 99EB14B9DB6B for ; Mon, 14 Sep 2026 17:00:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 99EB14B9DB6B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 99EB14B9DB6B Authentication-Results: sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789405202; cv=none; b=qzC8bl2Opci260rYTdiASiF/7bVewSABqCUCO5/aM8Zr2KeUjscVsFDzcu34SMu2KiHM4ij4yKedNSjILJ/+rt60wA0dYrRDfepKjSSoTmTf2wj2dHR+/t7lsxzEtIwEqqaXvqb+QbDlu+6JDvHmPkOqIORdA/i32lu7ImY/GOQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789405202; c=relaxed/simple; bh=N7YjrTEEComwkTmf/7sBd9unFMuhbe8svW4S28RrTeY=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=DfdCHC/e07skcnsvG9BgshetUkTGBB4C1d9VyB2p2x3RC8lOVn6DxPZgc2g+wRTsyjSP3IZ23QB31TxbtjKIDstUpPlT35kG6bxNlTKWRTidgYlEVzbhjapcxKWZKWlE9gCuLlgIkMUWrdvfUDTXrz5j1guX4964tRa3M/+E0KQ= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=LFBEznnK reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 99EB14B9DB6B Received: from eig-obgw-5002b.ext.cloudfilter.net ([10.0.29.226]) by cmsmtp with ESMTPS id 61bgxuMkGaC0U6A2CxyIzh; Mon, 14 Sep 2026 17:00:00 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 6A2Axqf9BadLA6A2BxUa15; Mon, 14 Sep 2026 16:59:59 +0000 X-Authority-Analysis: v=2.4 cv=Aqzu3P9P c=1 sm=1 tr=0 ts=6aa8280f a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=VdqzKS8jKosA:10 a=ItBw4LHWJt0A:10 a=dzWzf_mpAAAA:8 a=YGGSJV3aiD6oCLrGsFsA:9 a=b4DR9a7p2ZdsqdHBznES:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Unsubscribe-Post: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ILKmOdx5og5KfeCVV084/C8eYgv5ZgqoHiWq1hRaSS4=; b=LFBEznnKGI+gbm7wPAjalieXqL y3PvGikay7wAPxBCgvIGq6zhtXm5brBeQsKSnyxUg4K8XeYnf4VDJsWpf9oAMRooftSp7B62nKrSG QjvGUopbUTrKCBWhJE+jOa0/q; Received: from 75-166-229-74.hlrn.qwest.net ([75.166.229.74]:54020 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.100) (envelope-from ) id 1x6A2A-00000002DUA-2Cjm; Mon, 14 Sep 2026 10:59:58 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 1/4] Change evpy_emit_event to accept a gdbpy_opt_borrowed_ref In-Reply-To: <8c6dadb8-d305-4df8-b5ac-42c15a34b734@simark.ca> (Simon Marchi's message of "Mon, 14 Sep 2026 11:42:47 -0400") References: <20260808-python-safety-events-simple-v1-0-132aea40c801@tromey.com> <20260808-python-safety-events-simple-v1-1-132aea40c801@tromey.com> <8c6dadb8-d305-4df8-b5ac-42c15a34b734@simark.ca> X-Attribution: Tom Date: Mon, 14 Sep 2026 10:59:57 -0600 Message-ID: <87y0d36a5u.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.229.74 X-Source-L: No X-Exim-ID: 1x6A2A-00000002DUA-2Cjm X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-229-74.hlrn.qwest.net (prentzel) [75.166.229.74]:54020 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfNUYWWd48AzaIcf18clQoemReStESAfIAcyOjRDPlxFRop+09AsxrmkLFh6bMwajV/kNb7eWfdcxnV8jyr5tuf98snmrXcZ6SYpwHOhfeBsghB1nvlYd cy2+OHaQpNm7wO3z3GQCMmCkWrOJ+wu2bgR/r5eFya7tC8HMbp9EyhbN1nyizT/DSjg9vXOhXE7HV4zI12IuFxXDl1RULJdp4ec= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: Simon> Unrelated, but those two if could be collapsed into one with &&. Yeah, I normally don't care about this kind of thing. Simon> Also unrelated: I would change evregpy_no_listeners_p to Simon> evregpy_has_listeners_p, because double-negative is confusing. Simon> I can make following patches to change those. Alright. Simon> Copying a review comment from Claude that seems important: [...] Yeah. I think there's a longstanding GCC bug about not warning about this. Anyway I fixed it. Simon> Otherwise, it also noted: Simon> - gdb/python/py-breakpoint.c:1309 and :1340: both calls now fit on one line. I don't know which lines these are but the obvious-to-me choices end up at 81/82 characters and so can't be changed. Tom