From: Tom Tromey <tromey@redhat.com>
To: Hui Zhu <teawater@gmail.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>,
Stan Shebs <stan_shebs@mentor.com>,
Yao Qi <Yao_Qi@mentor.com>, Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH]Add option "-at" to "maint agent" and "maint agent-eval"
Date: Wed, 27 Jun 2012 18:37:00 -0000 [thread overview]
Message-ID: <87wr2s61p9.fsf@fleche.redhat.com> (raw)
In-Reply-To: <CANFwon2gboB-_waNACh1jSxrsXeuDSsEq=+b2yDnQV1Q1x4e+g@mail.gmail.com> (Hui Zhu's message of "Sun, 24 Jun 2012 14:59:08 +0800")
>>>>> ">" == Hui Zhu <teawater@gmail.com> writes:
>> 2012-06-24 Hui Zhu <hui_zhu@mentor.com>
>> * ax-gdb.c (cli/cli-utils.h): New include.
>> (linespec.h): Ditto.
>> (agent_eval_command_one): New function.
>> (agent_command_1): Ditto.
>> (agent_command): Call function agent_command_1.
>> (agent_eval_command): Ditto.
>> (_initialize_ax_gdb): Change help for "maint agent"
>> and "maint agent-eval".
This is also ok. I think it may slightly abuse linespec parsing, but
considering that it is a 'maint' command, I don't think it matters, as
we are free to say "don't do that", or change it as needed.
>> + expr = parse_exp_1 (&exp, block_for_pc (pc), 0);
You'll need a minor tweak to get it to compile, since I changed
parse_exp_1 today.
Tom
next prev parent reply other threads:[~2012-06-27 18:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-24 7:00 Hui Zhu
2012-06-27 17:46 ` Eli Zaretskii
2012-07-05 0:38 ` Hui Zhu
2012-06-27 18:28 ` Tom Tromey
2012-06-27 18:37 ` Tom Tromey [this message]
2012-07-05 1:15 ` Hui Zhu
2012-06-28 2:46 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wr2s61p9.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=Yao_Qi@mentor.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=stan_shebs@mentor.com \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox