From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-92505-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 10116 invoked by alias); 27 Jun 2012 18:37:44 -0000
Received: (qmail 10021 invoked by uid 22791); 27 Jun 2012 18:37:43 -0000
X-SWARE-Spam-Status: No, hits=-6.5 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 27 Jun 2012 18:37:30 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q5RIbNSc032406	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Wed, 27 Jun 2012 14:37:23 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q5RIbMvY005740	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Wed, 27 Jun 2012 14:37:22 -0400
From: Tom Tromey <tromey@redhat.com>
To: Hui Zhu <teawater@gmail.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>,        Stan Shebs <stan_shebs@mentor.com>, Yao Qi <Yao_Qi@mentor.com>,        Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH]Add option "-at" to "maint agent" and "maint agent-eval"
References: <CANFwon2gboB-_waNACh1jSxrsXeuDSsEq=+b2yDnQV1Q1x4e+g@mail.gmail.com>
Date: Wed, 27 Jun 2012 18:37:00 -0000
In-Reply-To: <CANFwon2gboB-_waNACh1jSxrsXeuDSsEq=+b2yDnQV1Q1x4e+g@mail.gmail.com>	(Hui Zhu's message of "Sun, 24 Jun 2012 14:59:08 +0800")
Message-ID: <87wr2s61p9.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-06/txt/msg00838.txt.bz2

>>>>> ">" == Hui Zhu <teawater@gmail.com> writes:

>> 2012-06-24  Hui Zhu  <hui_zhu@mentor.com>
>> 	* ax-gdb.c (cli/cli-utils.h): New include.
>> 	(linespec.h): Ditto.
>> 	(agent_eval_command_one): New function.
>> 	(agent_command_1): Ditto.
>> 	(agent_command): Call function agent_command_1.
>> 	(agent_eval_command): Ditto.
>> 	(_initialize_ax_gdb): Change help for "maint agent"
>> 	and "maint agent-eval".

This is also ok.  I think it may slightly abuse linespec parsing, but
considering that it is a 'maint' command, I don't think it matters, as
we are free to say "don't do that", or change it as needed.

>> +      expr = parse_exp_1 (&exp, block_for_pc (pc), 0);

You'll need a minor tweak to get it to compile, since I changed
parse_exp_1 today.

Tom