From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Regression for gdb.base/completion.exp [Re: RFC: completion for "set cp-abi"]
Date: Thu, 17 Jan 2013 20:23:00 -0000 [thread overview]
Message-ID: <87wqvbblu7.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20130117200311.GA14050@host2.jankratochvil.net> (Jan Kratochvil's message of "Thu, 17 Jan 2013 21:03:11 +0100")
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Jan> regressing on {x86_64,x86_64-m32,i686}-fedora18-linux-gnu (-lmcheck
Jan> in use).
Sorry about that.
It was a typo in the new function.
Here is the fix I am checking in.
I verified it using valgrind.
Tom
2013-01-17 Tom Tromey <tromey@redhat.com>
* cp-abi.c (cp_abi_completer): Fix typo in assignment.
Index: cp-abi.c
===================================================================
RCS file: /cvs/src/src/gdb/cp-abi.c,v
retrieving revision 1.38
diff -u -r1.38 cp-abi.c
--- cp-abi.c 17 Jan 2013 16:27:33 -0000 1.38
+++ cp-abi.c 17 Jan 2013 20:21:41 -0000
@@ -329,7 +329,7 @@
cp_abi_names = XNEWVEC (const char *, num_cp_abis + 1);
for (i = 0; i < num_cp_abis; ++i)
cp_abi_names[i] = cp_abis[i]->shortname;
- cp_abis[i] = NULL;
+ cp_abi_names[i] = NULL;
}
return complete_on_enum (cp_abi_names, text, word);
prev parent reply other threads:[~2013-01-17 20:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-08 16:42 RFC: completion for "set cp-abi" Tom Tromey
2013-01-17 16:25 ` Tom Tromey
2013-01-17 20:03 ` Regression for gdb.base/completion.exp [Re: RFC: completion for "set cp-abi"] Jan Kratochvil
2013-01-17 20:23 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wqvbblu7.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox