From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-97747-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 22262 invoked by alias); 17 Jan 2013 20:23:26 -0000
Received: (qmail 22249 invoked by uid 22791); 17 Jan 2013 20:23:25 -0000
X-SWARE-Spam-Status: No, hits=-6.5 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 17 Jan 2013 20:23:14 +0000
Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0HKNENw020443	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Thu, 17 Jan 2013 15:23:14 -0500
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r0HKNDNl026001	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Thu, 17 Jan 2013 15:23:13 -0500
From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Regression for gdb.base/completion.exp  [Re: RFC: completion for "set cp-abi"]
References: <87zk0j39ug.fsf@fleche.redhat.com>	<87pq13dbeo.fsf@fleche.redhat.com>	<20130117200311.GA14050@host2.jankratochvil.net>
Date: Thu, 17 Jan 2013 20:23:00 -0000
In-Reply-To: <20130117200311.GA14050@host2.jankratochvil.net> (Jan	Kratochvil's message of "Thu, 17 Jan 2013 21:03:11 +0100")
Message-ID: <87wqvbblu7.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.91 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2013-01/txt/msg00377.txt.bz2

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Jan> regressing on {x86_64,x86_64-m32,i686}-fedora18-linux-gnu (-lmcheck
Jan> in use).

Sorry about that.
It was a typo in the new function.

Here is the fix I am checking in.
I verified it using valgrind.

Tom

2013-01-17  Tom Tromey  <tromey@redhat.com>

	* cp-abi.c (cp_abi_completer): Fix typo in assignment.

Index: cp-abi.c
===================================================================
RCS file: /cvs/src/src/gdb/cp-abi.c,v
retrieving revision 1.38
diff -u -r1.38 cp-abi.c
--- cp-abi.c	17 Jan 2013 16:27:33 -0000	1.38
+++ cp-abi.c	17 Jan 2013 20:21:41 -0000
@@ -329,7 +329,7 @@
       cp_abi_names = XNEWVEC (const char *, num_cp_abis + 1);
       for (i = 0; i < num_cp_abis; ++i)
 	cp_abi_names[i] = cp_abis[i]->shortname;
-      cp_abis[i] = NULL;
+      cp_abi_names[i] = NULL;
     }
 
   return complete_on_enum (cp_abi_names, text, word);