Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: GDB Patches <gdb-patches@sourceware.org>,
	Keith Seitz <keiths@redhat.com>
Subject: Re: [PATCH] Fix for PR c++/15203 and PR c++/15210
Date: Wed, 13 Mar 2013 20:16:00 -0000	[thread overview]
Message-ID: <87wqtb9ht6.fsf@fleche.redhat.com> (raw)
In-Reply-To: <m3a9qdnmti.fsf@redhat.com> (Sergio Durigan Junior's message of	"Sat, 09 Mar 2013 02:50:49 -0300")

>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:

Sergio> And then, printing the value of `var':
Sergio>     (gdb) print 'foo::bar()::var'
Sergio> GDB would fall in an internal_error:

Sergio> This may not be the ideal solution, according to Keith it would
Sergio> be good to implement productions on c-exp.y in order to
Sergio> recognize CLASS::FUNCTION::VARIABLE, but it is a solution which
Sergio> works with what we have today.

I'm not sure about this idea.  Extensions make me a bit nervous, I
suppose.

Sergio> +      else if (sym->flags & (BSF_GLOBAL | BSF_LOCAL | BSF_WEAK | BSF_GNU_UNIQUE))

I think this line is too long.

Sergio> +# Regression test for PR c++/15203 and PR c++/15210
Sergio> +gdb_test "print 'gnu_obj_1::method()::sintvar'" "\\$\[0-9\]+ = 4" \
Sergio> +	   "simple object, static const int, accessing via 'class::method::variable"

I think the second line should only be indented 4 spaces.

Ok with those changes.

Tom


  parent reply	other threads:[~2013-03-13 20:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-09  5:51 Sergio Durigan Junior
2013-03-13  3:34 ` Sergio Durigan Junior
2013-03-13 20:16 ` Tom Tromey [this message]
2013-03-14 11:16   ` Sergio Durigan Junior
2013-03-14 11:55     ` Sergio Durigan Junior
2013-03-14 14:55       ` Tom Tromey
2013-03-19 14:44         ` Sergio Durigan Junior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wqtb9ht6.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=keiths@redhat.com \
    --cc=sergiodj@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox