From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24091 invoked by alias); 13 Mar 2013 20:16:30 -0000 Received: (qmail 24064 invoked by uid 22791); 13 Mar 2013 20:16:27 -0000 X-SWARE-Spam-Status: No, hits=-7.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 13 Mar 2013 20:16:22 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2DKGMXJ006690 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 13 Mar 2013 16:16:22 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r2DKGLt3030386 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 13 Mar 2013 16:16:21 -0400 From: Tom Tromey To: Sergio Durigan Junior Cc: GDB Patches , Keith Seitz Subject: Re: [PATCH] Fix for PR c++/15203 and PR c++/15210 References: Date: Wed, 13 Mar 2013 20:16:00 -0000 In-Reply-To: (Sergio Durigan Junior's message of "Sat, 09 Mar 2013 02:50:49 -0300") Message-ID: <87wqtb9ht6.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00607.txt.bz2 >>>>> "Sergio" == Sergio Durigan Junior writes: Sergio> And then, printing the value of `var': Sergio> (gdb) print 'foo::bar()::var' Sergio> GDB would fall in an internal_error: Sergio> This may not be the ideal solution, according to Keith it would Sergio> be good to implement productions on c-exp.y in order to Sergio> recognize CLASS::FUNCTION::VARIABLE, but it is a solution which Sergio> works with what we have today. I'm not sure about this idea. Extensions make me a bit nervous, I suppose. Sergio> + else if (sym->flags & (BSF_GLOBAL | BSF_LOCAL | BSF_WEAK | BSF_GNU_UNIQUE)) I think this line is too long. Sergio> +# Regression test for PR c++/15203 and PR c++/15210 Sergio> +gdb_test "print 'gnu_obj_1::method()::sintvar'" "\\$\[0-9\]+ = 4" \ Sergio> + "simple object, static const int, accessing via 'class::method::variable" I think the second line should only be indented 4 spaces. Ok with those changes. Tom