From: Tom Tromey <tromey@redhat.com>
To: manjian2006@gmail.com
Cc: gdb-patches@sourceware.org, linzj <linzj@ucweb.com>
Subject: Re: [PATCH] fixed inherit_abstract_dies infinite recursive call
Date: Mon, 20 Jan 2014 05:53:00 -0000 [thread overview]
Message-ID: <87wqhvi4gs.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1390191898-2635-1-git-send-email-manjian2006@gmail.com> (manjian's message of "Mon, 20 Jan 2014 12:24:58 +0800")
>>>>> ">" == manjian2006 <manjian2006@gmail.com> writes:
>> From: linzj <linzj@ucweb.com>
>> A dwarf die may have the following relationship:
>> 564860c<-----------------------------
>> | |
>> |(abstract origin) |
>> | |
>> V |
>> 5816d55 | (abstract origin)
>> | |
>> |(child) |
>> | |
>> V |
>> ... |
>> 5812c34------------------------------
What does it mean when this happens?
It seems very strange to me, like it must be a compiler bug.
>> + /* True if this die is in process */
Comments must end with a period and two spaces.
I would write something like "True if this DIE is currently being
processed." though.
>> + /* Only process those who are not in process */
Ditto about the formatting.
>> + if(die->in_process)
Space before open paren.
I think this needs a test case.
It should be possible, I think, to write one using the DWARF assembler.
Tom
next prev parent reply other threads:[~2014-01-20 5:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-20 4:25 manjian2006
2014-01-20 5:53 ` Tom Tromey [this message]
2014-01-21 1:43 ` manjian2006
2014-01-21 7:54 ` Joel Brobecker
2014-01-21 10:17 ` manjian2006
2014-01-20 6:30 ` manjian2006
2014-01-22 2:45 ` Doug Evans
-- strict thread matches above, loose matches on Subject: below --
2014-01-20 6:22 manjian2006
2014-01-20 3:41 manjian2006
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wqhvi4gs.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=linzj@ucweb.com \
--cc=manjian2006@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox