From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3307 invoked by alias); 20 Jan 2014 05:53:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3295 invoked by uid 89); 20 Jan 2014 05:53:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 20 Jan 2014 05:53:44 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0K5rfaN017056 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 20 Jan 2014 00:53:41 -0500 Received: from barimba (ovpn-113-85.phx2.redhat.com [10.3.113.85]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s0K5rdDp000890 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 20 Jan 2014 00:53:40 -0500 From: Tom Tromey To: manjian2006@gmail.com Cc: gdb-patches@sourceware.org, linzj Subject: Re: [PATCH] fixed inherit_abstract_dies infinite recursive call References: <1390191898-2635-1-git-send-email-manjian2006@gmail.com> Date: Mon, 20 Jan 2014 05:53:00 -0000 In-Reply-To: <1390191898-2635-1-git-send-email-manjian2006@gmail.com> (manjian's message of "Mon, 20 Jan 2014 12:24:58 +0800") Message-ID: <87wqhvi4gs.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2014-01/txt/msg00733.txt.bz2 >>>>> ">" == manjian2006 writes: >> From: linzj >> A dwarf die may have the following relationship: >> 564860c<----------------------------- >> | | >> |(abstract origin) | >> | | >> V | >> 5816d55 | (abstract origin) >> | | >> |(child) | >> | | >> V | >> ... | >> 5812c34------------------------------ What does it mean when this happens? It seems very strange to me, like it must be a compiler bug. >> + /* True if this die is in process */ Comments must end with a period and two spaces. I would write something like "True if this DIE is currently being processed." though. >> + /* Only process those who are not in process */ Ditto about the formatting. >> + if(die->in_process) Space before open paren. I think this needs a test case. It should be possible, I think, to write one using the DWARF assembler. Tom