Re: [PATCH 3/4] Create syscall groups for x86_64.

[Sergio Durigan Junior <sergiodj@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 2187 bytes --]

On Wednesday, November 19 2014, Gabriel Krisman Bertazi wrote:

> Sergio Durigan Junior <sergiodj@redhat.com> writes:
>
> Sergio,
>
> Thank you for your review.  I applied your suggestions and I will send
> the updated patches to this list in a few moments.

Thanks!

>> On Sunday, November 02 2014, Gabriel Krisman Bertazi wrote:
>>
>>> This commit introduces the following syscall groups for the x86_64
>>> architecture: memory, ipc, process, descriptor, signal and file.
>>>
>>> Please note that the sorting of the syscalls among these several groups
>>> follows the same structure used in strace.
>>>
>>> This also introduces tests for catching groups of syscalls on the x86_64
>>> architecture.
>>
>> I guess I said that before, but just in case I didn't: I would prefer if
>> this patch already updated the other architectures as well.  IIUC you
>> are planning to do that in another series of patches, but it would be
>> good if you did everything at once, I think.  However, I will not oppose
>> if you decide to touch only on x86_64 for now.
>
> Updating the syscall files by hand is quite error-prone and requires
> lots of typing.  Should we bring PR 14276 to the table, it would also
> require extra work to update the groups later.

Yeah, I am aware of that :-/.

> A few weeks ago, you and I talked about writing a script to fix PR14276.
> What I want to do is to save me some typing now and update the other
> architectures only after we have such script to generate the syscall
> files, so we can use it to also generate the group information
> automatically.  What do you think? Is that ok for you?

Heh, since you asked :-P...

My opinion is that writing this script could take some time, and I am
not counting on it be to ready soon, unfortunately.

That being said, I also don't think we should let the perfect be the
enemy of the good (I think Pedro said that once, and I liked the
phrase).  Therefore, I am OK with your patch as is, provided we don't
take too long to start working on this script :-).

Thanks,

-- 
Sergio
GPG key ID: 0x65FC5E36
Please send encrypted e-mail if possible
http://sergiodj.net/

[-- Attachment #2: Type: application/pgp-signature, Size: 818 bytes --]