Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Gabriel Krisman Bertazi <gabriel@krisman.be>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 4/4] Update documentation on catching a group of related syscalls.
Date: Fri, 14 Nov 2014 20:38:00 -0000	[thread overview]
Message-ID: <83ppcph623.fsf@gnu.org> (raw)
In-Reply-To: <87ioih398l.fsf@krisman.be>

> From: Gabriel Krisman Bertazi <gabriel@krisman.be>
> Cc: gdb-patches@sourceware.org
> Date: Fri, 14 Nov 2014 16:52:42 -0200
> 
> --- a/gdb/breakpoint.c
> +++ b/gdb/breakpoint.c
> @@ -16736,11 +16736,11 @@ If REGEX is given, only stop for libraries matching the regular expression."),
>  		     CATCH_PERMANENT,
>  		     CATCH_TEMPORARY);
>    add_catch_command ("syscall", _("\
> -Catch system calls by their names and/or numbers.\n\
> -Arguments say which system calls to catch.  If no arguments\n\
> -are given, every system call will be caught.\n\
> -Arguments, if given, should be one or more system call names\n\
> -(if your system supports that), or system call numbers."),
> +Catch system calls by their names, groups and/or numbers.  Arguments\n\
> +say which system calls to catch.  If no arguments are given, every\n\
> +system call will be caught.  Arguments, if given, should be one or\n\
> +more system call names (if your system supports that), system call\n\
> +groups or system call numbers."),

The first line of the doc string must be a single complete sentence
terminated by a period.  That's because some help-related commands
stop displaying at the first period.

Otherwise, these patches are OK.

Thanks.


  reply	other threads:[~2014-11-14 20:38 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-02 19:36 [PATCH 0/4] Catch syscall groups Gabriel Krisman Bertazi
2014-11-02 19:36 ` [PATCH 1/4] Implemement support for groups of syscalls in the xml-syscall interface Gabriel Krisman Bertazi
2014-11-14 22:42   ` Sergio Durigan Junior
2014-11-02 19:36 ` [PATCH 2/4] Add support to catch groups of syscalls Gabriel Krisman Bertazi
2014-11-14 22:55   ` Sergio Durigan Junior
2014-11-02 19:37 ` [PATCH 3/4] Create syscall groups for x86_64 Gabriel Krisman Bertazi
2014-11-14 23:00   ` Sergio Durigan Junior
2014-11-20  2:11     ` Gabriel Krisman Bertazi
2014-11-20  3:08       ` Sergio Durigan Junior
2014-11-02 19:37 ` [PATCH 4/4] Update documentation on catching a group of related syscalls Gabriel Krisman Bertazi
2014-11-02 19:45   ` Eli Zaretskii
2014-11-12  2:04     ` Gabriel Krisman Bertazi
2014-11-12  3:48       ` Eli Zaretskii
2014-11-14 18:52         ` Gabriel Krisman Bertazi
2014-11-14 20:38           ` Eli Zaretskii [this message]
2014-11-03 18:38   ` Sergio Durigan Junior
2014-11-21 19:05 ` [PATCH v2 2/4] Add support to catch groups of syscalls Gabriel Krisman Bertazi
2014-11-21 21:34   ` Sergio Durigan Junior
2015-01-15  8:12   ` Doug Evans
2014-11-21 19:05 ` [PATCH v2 1/4] Implemement support for groups of syscalls in the xml-syscall interface Gabriel Krisman Bertazi
2014-11-29  0:19   ` [ping PATCH " Gabriel Krisman Bertazi
2014-12-08  0:09     ` [ping^2 " Gabriel Krisman Bertazi
2014-12-21 15:59       ` [ping^3 " Gabriel Krisman Bertazi
2015-01-12 20:47         ` Doug Evans
2015-01-15  8:03   ` [PATCH " Doug Evans
2015-01-29  4:43     ` Gabriel Krisman Bertazi
2015-01-29  7:42       ` Doug Evans
2014-11-21 19:06 ` [PATCH v2 3/4] Create syscall groups for x86_64 Gabriel Krisman Bertazi
2015-01-15  8:28   ` Doug Evans
2014-11-21 19:06 ` [PATCH v2 4/4] Update documentation on catching a group of related syscalls Gabriel Krisman Bertazi
2014-11-21 19:48   ` Eli Zaretskii
2014-11-26  3:58     ` Gabriel Krisman Bertazi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83ppcph623.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gabriel@krisman.be \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox