From: Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
To: Pedro Alves <palves@redhat.com>,
Joel Brobecker <brobecker@adacore.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix testsuite hangs when gdb_test_multiple body errors out (Re: GDB 8.2.90 available for testing)
Date: Fri, 22 Mar 2019 20:44:00 -0000 [thread overview]
Message-ID: <87wokqd4gj.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <4d855905-32ce-ba4b-72f5-037f1796b37e@redhat.com>
Pedro Alves <palves@redhat.com> writes:
Hello,
> I spent a while trying to fix this, and I came up with the patch below.
>
> WDYT?
Makes sense to me.
> So this commit solves this by appending an "eof" with an empty
> spawn_id list, so that it won't ever match.
This is a clever solution, but just to be sure, can we actually rely on
this behavior when the list is empty? This did work when I tested it,
but could some Expect version conceivably do something else like
returning an error when parsing a body with a "-i" that uses an empty
list?
> gdb/ChangeLog:
> yyyy-mm-dd Pedro Alves <palves@redhat.com>
I think you meant gdb/testsuite/ChangeLog
Thanks for the patch!
--
Pedro Franco de Carvalho
next prev parent reply other threads:[~2019-03-22 20:44 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-27 5:51 GDB 8.2.90 available for testing Joel Brobecker
2019-02-27 22:05 ` Jim Wilson
2019-03-04 11:15 ` Andrew Burgess
2019-03-04 13:57 ` Alan Hayward
2019-03-04 20:00 ` Jim Wilson
2019-02-28 18:31 ` MinGW build of GDB 8.2.90 (was: GDB 8.2.90 available for testing) Eli Zaretskii
2019-02-28 18:55 ` MinGW build of GDB 8.2.90 Sergio Durigan Junior
2019-02-28 19:06 ` LRN
2019-02-28 19:45 ` Eli Zaretskii
2019-02-28 20:17 ` Sergio Durigan Junior
2019-02-28 20:29 ` Eli Zaretskii
2019-02-28 20:37 ` Sergio Durigan Junior
2019-02-28 18:34 ` GDB 8.2.90 available for testing Eli Zaretskii
2019-03-01 16:35 ` Pedro Alves
2019-03-01 18:50 ` Tom Tromey
2019-03-07 22:44 ` Tom Tromey
2019-03-08 7:46 ` Eli Zaretskii
2019-03-08 20:57 ` Tom Tromey
2019-03-09 6:13 ` Eli Zaretskii
2019-03-14 17:32 ` Tom Tromey
2019-03-14 19:49 ` Eli Zaretskii
2019-03-15 12:55 ` Tom Tromey
2019-03-17 15:56 ` Eli Zaretskii
2019-03-17 17:31 ` Tom Tromey
2019-03-17 18:36 ` Eli Zaretskii
2019-03-18 14:13 ` Tom Tromey
2019-03-18 18:08 ` Eli Zaretskii
2019-03-07 17:42 ` Pedro Franco de Carvalho
[not found] ` <4d855905-32ce-ba4b-72f5-037f1796b37e@redhat.com>
2019-03-22 14:42 ` [PATCH] Fix testsuite hangs when gdb_test_multiple body errors out (Re: GDB 8.2.90 available for testing) Simon Marchi
2019-03-25 13:23 ` Pedro Alves
2019-03-22 20:44 ` Pedro Franco de Carvalho [this message]
2019-03-25 13:21 ` Pedro Alves
2019-03-25 19:43 ` Pedro Franco de Carvalho
2019-03-26 18:58 ` Pedro Alves
2019-03-26 21:01 ` Pedro Franco de Carvalho
2019-03-28 17:36 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wokqd4gj.fsf@linux.vnet.ibm.com \
--to=pedromfc@linux.ibm.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox