From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 124127 invoked by alias); 22 Mar 2019 20:44:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 124093 invoked by uid 89); 22 Mar 2019 20:44:40 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=BAYES_00,KHOP_DYNAMIC,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.1 spammy=HX-Languages-Length:818, patch!, spent X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 22 Mar 2019 20:44:38 +0000 Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x2MKhqao057965 for ; Fri, 22 Mar 2019 16:44:37 -0400 Received: from e31.co.us.ibm.com (e31.co.us.ibm.com [32.97.110.149]) by mx0b-001b2d01.pphosted.com with ESMTP id 2rd5x02p1e-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 22 Mar 2019 16:44:37 -0400 Received: from localhost by e31.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 22 Mar 2019 20:44:34 -0000 Received: from b03cxnp08027.gho.boulder.ibm.com (9.17.130.19) by e31.co.us.ibm.com (192.168.1.131) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Fri, 22 Mar 2019 20:44:31 -0000 Received: from b03ledav004.gho.boulder.ibm.com (b03ledav004.gho.boulder.ibm.com [9.17.130.235]) by b03cxnp08027.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x2MKiWkR60555394 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 22 Mar 2019 20:44:32 GMT Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0B5C07805F; Fri, 22 Mar 2019 20:44:32 +0000 (GMT) Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B8BD278063; Fri, 22 Mar 2019 20:44:31 +0000 (GMT) Received: from pedro.localdomain (unknown [9.85.183.195]) by b03ledav004.gho.boulder.ibm.com (Postfix) with ESMTP; Fri, 22 Mar 2019 20:44:31 +0000 (GMT) Received: by pedro.localdomain (Postfix, from userid 1000) id DA9103C0FA6; Fri, 22 Mar 2019 17:44:28 -0300 (-03) From: Pedro Franco de Carvalho To: Pedro Alves , Joel Brobecker , gdb-patches@sourceware.org Subject: Re: [PATCH] Fix testsuite hangs when gdb_test_multiple body errors out (Re: GDB 8.2.90 available for testing) In-Reply-To: <4d855905-32ce-ba4b-72f5-037f1796b37e@redhat.com> References: <20190227055112.4A5E782D7B@joel.gnat.com> <8736ny7f8u.fsf@linux.vnet.ibm.com> <4d855905-32ce-ba4b-72f5-037f1796b37e@redhat.com> Date: Fri, 22 Mar 2019 20:44:00 -0000 MIME-Version: 1.0 Content-Type: text/plain x-cbid: 19032220-8235-0000-0000-00000E7223AF X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00010796; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000282; SDB=6.01178181; UDB=6.00616391; IPR=6.00958880; MB=3.00026116; MTD=3.00000008; XFM=3.00000015; UTC=2019-03-22 20:44:32 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19032220-8236-0000-0000-000044DEBD2E Message-Id: <87wokqd4gj.fsf@linux.vnet.ibm.com> X-IsSubscribed: yes X-SW-Source: 2019-03/txt/msg00491.txt.bz2 Pedro Alves writes: Hello, > I spent a while trying to fix this, and I came up with the patch below. > > WDYT? Makes sense to me. > So this commit solves this by appending an "eof" with an empty > spawn_id list, so that it won't ever match. This is a clever solution, but just to be sure, can we actually rely on this behavior when the list is empty? This did work when I tested it, but could some Expect version conceivably do something else like returning an error when parsing a body with a "-i" that uses an empty list? > gdb/ChangeLog: > yyyy-mm-dd Pedro Alves I think you meant gdb/testsuite/ChangeLog Thanks for the patch! -- Pedro Franco de Carvalho