From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb/symtab] Handle DW_AT_decl_file with form DW_FORM_implicit_const
Date: Wed, 24 Feb 2021 13:35:17 -0700 [thread overview]
Message-ID: <87wnuxyzju.fsf@tromey.com> (raw)
In-Reply-To: <20210205122854.GA19272@delia> (Tom de Vries's message of "Fri, 5 Feb 2021 13:28:55 +0100")
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> 2021-02-05 Tom de Vries <tdevries@suse.de>
Tom> PR symtab/27336
Tom> * dwarf2/attribute.c (attribute::form_is_signed): New function
Tom> factored out of ...
Tom> * dwarf2/attribute.h (attribute::as_signed): ... here.
Tom> (attribute::is_nonnegative, attribute::as_nonnegative): New function.
Tom> (attribute::form_is_signed): Declare.
Tom> * dwarf2/read.c (new_symbol): Use is_nonnegative and as_nonnegative
Tom> for DW_AT_decl_file.
Thank you for doing this.
Tom> + if (form_is_signed ())
Tom> + return as_signed () >= (LONGEST)0;
I don't think this cast is needed.
Otherwise this looks good to me.
Tom
prev parent reply other threads:[~2021-02-24 20:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 12:28 Tom de Vries
2021-02-24 8:14 ` [PING][PATCH][gdb/symtab] " Tom de Vries
2021-02-24 20:35 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wnuxyzju.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox