From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id oe2ZCoq4NmA8IAAAWB0awg (envelope-from ) for ; Wed, 24 Feb 2021 15:35:22 -0500 Received: by simark.ca (Postfix, from userid 112) id 07ACD1EF78; Wed, 24 Feb 2021 15:35:22 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: * X-Spam-Status: No, score=1.6 required=5.0 tests=DKIM_SIGNED,MAILING_LIST_MULTI, RCVD_IN_BL_SPAMCOP_NET,RDNS_NONE,T_DKIM_INVALID,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A6FA01E789 for ; Wed, 24 Feb 2021 15:35:21 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 61FBC39540BC; Wed, 24 Feb 2021 20:35:21 +0000 (GMT) Received: from gateway34.websitewelcome.com (gateway34.websitewelcome.com [192.185.148.200]) by sourceware.org (Postfix) with ESMTPS id F2DD63857026 for ; Wed, 24 Feb 2021 20:35:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org F2DD63857026 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway34.websitewelcome.com (Postfix) with ESMTP id 7866C1DF598 for ; Wed, 24 Feb 2021 14:35:18 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id F0sQljzMsoE4DF0sQldoR0; Wed, 24 Feb 2021 14:35:18 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=gcGRNU7tk8waFz6OG1u2BZ4prUSGY8RBUl8DZcj32/0=; b=E07UMT9IbPkoLu6LxFgTyNfZi5 0udoo42OXfJkTWwp5OEABQdgArmcP6BLdI0qvIqSrDFPzyTsox49r3yxir7zNr1xbilX7LUrS9sVA P12LGQbAc4+X/aTjAvMA4wXi8; Received: from 97-122-70-152.hlrn.qwest.net ([97.122.70.152]:43348 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1lF0sP-00454p-Qw; Wed, 24 Feb 2021 13:35:17 -0700 From: Tom Tromey To: Tom de Vries Subject: Re: [PATCH][gdb/symtab] Handle DW_AT_decl_file with form DW_FORM_implicit_const References: <20210205122854.GA19272@delia> X-Attribution: Tom Date: Wed, 24 Feb 2021 13:35:17 -0700 In-Reply-To: <20210205122854.GA19272@delia> (Tom de Vries's message of "Fri, 5 Feb 2021 13:28:55 +0100") Message-ID: <87wnuxyzju.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.70.152 X-Source-L: No X-Exim-ID: 1lF0sP-00454p-Qw X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-70-152.hlrn.qwest.net (murgatroyd) [97.122.70.152]:43348 X-Source-Auth: tom+tromey.com X-Email-Count: 11 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>>>> "Tom" == Tom de Vries writes: Tom> 2021-02-05 Tom de Vries Tom> PR symtab/27336 Tom> * dwarf2/attribute.c (attribute::form_is_signed): New function Tom> factored out of ... Tom> * dwarf2/attribute.h (attribute::as_signed): ... here. Tom> (attribute::is_nonnegative, attribute::as_nonnegative): New function. Tom> (attribute::form_is_signed): Declare. Tom> * dwarf2/read.c (new_symbol): Use is_nonnegative and as_nonnegative Tom> for DW_AT_decl_file. Thank you for doing this. Tom> + if (form_is_signed ()) Tom> + return as_signed () >= (LONGEST)0; I don't think this cast is needed. Otherwise this looks good to me. Tom