From: Tom Tromey <tom@tromey.com>
To: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/3] gdb/ctf: don't create a buildsym_compunit when building partial symbols
Date: Mon, 04 Apr 2022 11:08:46 -0600 [thread overview]
Message-ID: <87wng4ixnl.fsf@tromey.com> (raw)
In-Reply-To: <20220331212019.2811099-1-simon.marchi@polymtl.ca> (Simon Marchi via Gdb-patches's message of "Thu, 31 Mar 2022 17:20:17 -0400")
>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
Simon> In ctfread.c, a buildsym_compunit is created in ctf_start_archive, which
Simon> is only used when creating partial symtabs. At this moment, I don't
Simon> see how that's useful.
It probably can't be, as those are different phases.
TBH, ctfread would probably be improved by not using psymtabs at all.
That is, if libctf provides by-name lookups, then there's really no need
to even have a psymtab.
Tom
prev parent reply other threads:[~2022-04-04 17:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 21:20 Simon Marchi via Gdb-patches
2022-03-31 21:20 ` [PATCH 2/3] gdb: print compunit_symtab name in "maint info symtabs" Simon Marchi via Gdb-patches
2022-03-31 21:20 ` [PATCH 3/3] gdb/ctf: pass partial symtab's filename to buildsym_compunit Simon Marchi via Gdb-patches
2022-04-01 0:07 ` Wei-min Pan via Gdb-patches
2022-03-31 23:56 ` [PATCH 1/3] gdb/ctf: don't create a buildsym_compunit when building partial symbols Wei-min Pan via Gdb-patches
2022-04-01 0:14 ` Simon Marchi via Gdb-patches
2022-04-01 0:57 ` Wei-min Pan via Gdb-patches
2022-04-01 1:32 ` Simon Marchi via Gdb-patches
2022-04-04 17:08 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wng4ixnl.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox