From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id zjB8Di0mS2JkSAAAWB0awg (envelope-from ) for ; Mon, 04 Apr 2022 13:09:01 -0400 Received: by simark.ca (Postfix, from userid 112) id 1F16B1F344; Mon, 4 Apr 2022 13:09:01 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8CDFD1EFB9 for ; Mon, 4 Apr 2022 13:09:00 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0E7173857820 for ; Mon, 4 Apr 2022 17:09:00 +0000 (GMT) Received: from gproxy3-pub.mail.unifiedlayer.com (gproxy3-pub.mail.unifiedlayer.com [69.89.30.42]) by sourceware.org (Postfix) with ESMTPS id 9DC7B3858C52 for ; Mon, 4 Apr 2022 17:08:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9DC7B3858C52 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw15.mail.unifiedlayer.com (unknown [10.0.90.130]) by progateway5.mail.pro1.eigbox.com (Postfix) with ESMTP id 05A2510047F50 for ; Mon, 4 Apr 2022 17:08:48 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id bQC7n46IDkku4bQC7nLpH9; Mon, 04 Apr 2022 17:08:48 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=R6XGpfdX c=1 sm=1 tr=0 ts=624b2620 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=z0gMJWrwH1QA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=QqokqNQhfL7E_4N4y_gA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=2+dJv3zxrIZg+5RnxuP0aq/bMaZiMEvxKpA5rnfjxTU=; b=lO4xSQ2Tt8ugvOsGpaF39EXs+K 3ZL25lmZm+BW6GN4ISFOw6S3OLlRmTpob5c89cH7xq58Ue6cKsKDj1m36u8WssIOlgdo+af4e+cYf /+Cyh7s+UDQ8/gETH1vXlQC7V; Received: from 71-211-176-135.hlrn.qwest.net ([71.211.176.135]:55398 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nbQC7-001KVo-4j; Mon, 04 Apr 2022 11:08:47 -0600 From: Tom Tromey To: Simon Marchi via Gdb-patches Subject: Re: [PATCH 1/3] gdb/ctf: don't create a buildsym_compunit when building partial symbols References: <20220331212019.2811099-1-simon.marchi@polymtl.ca> X-Attribution: Tom Date: Mon, 04 Apr 2022 11:08:46 -0600 In-Reply-To: <20220331212019.2811099-1-simon.marchi@polymtl.ca> (Simon Marchi via Gdb-patches's message of "Thu, 31 Mar 2022 17:20:17 -0400") Message-ID: <87wng4ixnl.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.176.135 X-Source-L: No X-Exim-ID: 1nbQC7-001KVo-4j X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-176-135.hlrn.qwest.net (murgatroyd) [71.211.176.135]:55398 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> In ctfread.c, a buildsym_compunit is created in ctf_start_archive, which Simon> is only used when creating partial symtabs. At this moment, I don't Simon> see how that's useful. It probably can't be, as those are different phases. TBH, ctfread would probably be improved by not using psymtabs at all. That is, if libctf provides by-name lookups, then there's really no need to even have a psymtab. Tom