Re: [PATCHv3] gdb: notify of inferior switch when needed from 'thread' command

[Andrew Burgess <aburgess@redhat.com>]

Andrew Burgess <aburgess@redhat.com> writes:

> I looked into the issues that Baris raised in this email:
>
>   https://inbox.sourceware.org/gdb-patches/IA0PR11MB7307BB4B5B3CC3A354289261C4C7A@IA0PR11MB7307.namprd11.prod.outlook.com
>
> About how in a multi-inferior debug session, if hitting a breakpoint
> triggers a thread AND inferior switch, then we announce the new
> thread, but not the new inferior.  This is very similar to the fix
> being proposed in this patch.
>
> However, in this case we don't use
> notify_user_selected_context_changed to announce the new
> thread/inferior, instead this is done in normal_stop (infrunc.c).
>
> I think we could and should change this code to announce the inferior
> switch where appropriate.  But given this change would be quite
> different to the changes in this patch, then my current plan is to do
> that in a follow up change once this is merged.
>
> Speaking of which, my current plan is to push this next week.  I don't
> think Pedro, who had feedback on V1, is actively reviewing patches any
> more, but if there's any feedback post-commit, I'm happy to discuss
> things then.
>
> In v3:
>
>   - Rebased and retested.
>
> In v2:
>
>   - Rebased and retested.
>
>   - Reworked commit message to try and address Pedro's concerns.

I've checked this in now.

Thanks,
Andrew