RE: [PATCH] gdb: notify of inferior switch when needed from 'thread' command

["Aktemur, Tankut Baris" <tankut.baris.aktemur@intel.com>]

Hello Andrew,

> I'd also like to draw you attention to the gdb/mi/* changes in this
> patch as you didn't give your thoughts on that aspect of the change.
> 
> That part of the patch handles the case where a user as an MI and CLI
> interpreter running, and the inferior/thread changes as a result of an
> MI action.
> 
> In this case, the MI action might be a click, or miss-click in a UI, or
> might even be some automated action by the MI frontend that the user
> didn't (knowingly) perform.  In this case, currently, the CLI will
> receive a thread/frame change notification (i.e. the CLI interpreter
> prints the new thread and frame), but the inferior notification is
> missing.  My patch changed GDB so the CLI would (when appropriate) also
> receive an inferior changed notification, and so also print a "Switching
> to inferior..." line.
> 
> Surely in that case, your "the inferior change is known from the
> command" argument doesn't apply, right?
> 
> But then there's a whole argument about consistency.  If I change
> inferior and thread via the MI the CLI gets a "Switching to inferior"
> line, but if I do the same switch via the CLI, I wouldn't.  Which I
> dislike.

Something is not clear to me.  Suppose there is an internal switch because
of a breakpoint hit.  E.g. My selected thread is 2.2.  I resume all inferiors.
Thread 1.1 hits a breakpoint.  GDB switches.  With your patch, the output is

  [Switching to Thread 0x7ffff7d85740 (LWP 1279258)]

  Thread 1.1 "test" hit Breakpoint ...

Should we have seen a "Switching to inferior 1 ...", too?

Best regards,
-Baris

> Anyway, I still feel like this change is the right thing to do.  I'd
> love to hear your thoughts on the points I've raised.
> 
> Clearly though, my original patch did a poor job of explaining that the
> extra "Switching to inferior" line would only appear when necessary, so
> if I can get you on board with this change, I'll rewrite the commit
> message to make that _much_ clearer.
> 
> Thanks,
> Andrew


Intel Deutschland GmbH
Registered Address: Dornacher Straße 1, 85622 Feldkirchen, Germany
Tel: +49 89 991 430, www.intel.de
Managing Directors: Harry Demas, Jeffrey Schneiderman, Yin Chong Sorrell
Chairperson of the Supervisory Board: Nicole Lau
Registered Seat: Munich
Commercial Register: Amtsgericht München HRB 186928