From: Richard Sandiford <rdsandiford@googlemail.com>
To: "Maciej W. Rozycki" <macro@codesourcery.com>
Cc: binutils@sourceware.org, gdb-patches@sourceware.org
Subject: Re: [PATCH] MIPS/BFD: Fix assertions with SGI IRIX files
Date: Wed, 31 Aug 2011 20:14:00 -0000 [thread overview]
Message-ID: <87vctdl4p1.fsf@firetop.home> (raw)
In-Reply-To: <alpine.DEB.1.10.1108311837450.5774@tp.orcam.me.uk> (Maciej W. Rozycki's message of "Wed, 31 Aug 2011 19:00:43 +0100 (BST)")
"Maciej W. Rozycki" <macro@codesourcery.com> writes:
>> A patch to remove the assertions is pre-approved if you agree that's OK.
>
> OK, but are you positive that'll be no regression?
This is binutils. You can never be positive that a patch won't break
something. But the handling of SHN_MIPS_DATA and SHN_MIPS_TEXT isn't
written in an SGI-specific way (just as the handling of the other
SHN_MIPS_* sections isn't written in an SGI-specific way). I couldn't see,
and still can't see, a reason why removing the assertions is wrong.
Richard
next prev parent reply other threads:[~2011-08-31 20:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <alpine.DEB.1.10.1108181530580.4083__36247.0631408089$1313685694$gmane$org@tp.orcam.me.uk>
2011-08-19 9:42 ` Richard Sandiford
2011-08-31 18:01 ` Maciej W. Rozycki
2011-08-31 20:14 ` Richard Sandiford [this message]
2011-09-02 10:06 ` Maciej W. Rozycki
2011-10-24 14:02 ` Maciej W. Rozycki
2011-11-15 17:29 ` Richard Sandiford
2011-11-16 12:37 ` Maciej W. Rozycki
2011-08-18 16:41 Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vctdl4p1.fsf@firetop.home \
--to=rdsandiford@googlemail.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=macro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox