From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-83419-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 1949 invoked by alias); 31 Aug 2011 20:14:07 -0000
Received: (qmail 1931 invoked by uid 22791); 31 Aug 2011 20:14:05 -0000
X-SWARE-Spam-Status: No, hits=-2.3 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW
X-Spam-Check-By: sourceware.org
Received: from mail-wy0-f169.google.com (HELO mail-wy0-f169.google.com) (74.125.82.169)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 31 Aug 2011 20:13:51 +0000
Received: by wyi11 with SMTP id 11so943391wyi.0        for <multiple recipients>; Wed, 31 Aug 2011 13:13:50 -0700 (PDT)
Received: by 10.227.207.129 with SMTP id fy1mr786328wbb.22.1314821629899;        Wed, 31 Aug 2011 13:13:49 -0700 (PDT)
Received: from localhost (rsandifo.gotadsl.co.uk [82.133.89.107])        by mx.google.com with ESMTPS id eo6sm2889258wbb.48.2011.08.31.13.13.47        (version=TLSv1/SSLv3 cipher=OTHER);        Wed, 31 Aug 2011 13:13:48 -0700 (PDT)
From: Richard Sandiford <rdsandiford@googlemail.com>
To: "Maciej W. Rozycki" <macro@codesourcery.com>
Mail-Followup-To: "Maciej W. Rozycki" <macro@codesourcery.com>,binutils@sourceware.org,  gdb-patches@sourceware.org, rdsandiford@googlemail.com
Cc: binutils@sourceware.org,  gdb-patches@sourceware.org
Subject: Re: [PATCH] MIPS/BFD: Fix assertions with SGI IRIX files
References: <alpine.DEB.1.10.1108181530580.4083__36247.0631408089$1313685694$gmane$org@tp.orcam.me.uk>	<m3hb5dpwk6.fsf@richards-thinkpad.stglab.manchester.uk.ibm.com>	<alpine.DEB.1.10.1108311837450.5774@tp.orcam.me.uk>
Date: Wed, 31 Aug 2011 20:14:00 -0000
In-Reply-To: <alpine.DEB.1.10.1108311837450.5774@tp.orcam.me.uk> (Maciej	W. Rozycki's message of "Wed, 31 Aug 2011 19:00:43 +0100 (BST)")
Message-ID: <87vctdl4p1.fsf@firetop.home>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-08/txt/msg00679.txt.bz2

"Maciej W. Rozycki" <macro@codesourcery.com> writes:
>> A patch to remove the assertions is pre-approved if you agree that's OK.
>
>  OK, but are you positive that'll be no regression?

This is binutils.  You can never be positive that a patch won't break
something.  But the handling of SHN_MIPS_DATA and SHN_MIPS_TEXT isn't
written in an SGI-specific way (just as the handling of the other
SHN_MIPS_* sections isn't written in an SGI-specific way).  I couldn't see,
and still can't see, a reason why removing the assertions is wrong.

Richard