From: Tom Tromey <tromey@redhat.com>
To: "Andrew Burgess" <aburgess@broadcom.com>
Cc: "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: Re-evaluate floating varobj as part of varobj_invalidate.
Date: Wed, 25 Jul 2012 17:52:00 -0000 [thread overview]
Message-ID: <87vchbhgo9.fsf@fleche.redhat.com> (raw)
In-Reply-To: <501025E0.30708@broadcom.com> (Andrew Burgess's message of "Wed, 25 Jul 2012 17:59:12 +0100")
>>>>> "Andrew" == Andrew Burgess <aburgess@broadcom.com> writes:
Andrew> I have a bug & patch, but no great way to reproduce the issue as
Andrew> it's a use of pointer after free issue,
I suspect the recent-ish change to use -lmcheck by default will cause us
to catch this bug in the test suite, at least on glibc-using systems.
Andrew> The patch below simply removes the special case for floating
Andrew> varobj objects from varobj_invalidate_iter, and causes them to
Andrew> be re-evaluated or marked as invalid.
Seems reasonable to me.
Andrew> 2012-07-25 Andrew Burgess <aburgess@broadcom.com>
Andrew> * varobj.c (varobj_invalidate_iter): All varobj must be marked as
Andrew> invalid or reevaluated to prevent prevent references to possibly
Andrew> delete'd type objects being left in the varobj.
Patch is ok.
Tom
next prev parent reply other threads:[~2012-07-25 17:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-25 16:59 Andrew Burgess
2012-07-25 17:52 ` Tom Tromey [this message]
2012-07-26 8:35 ` Jan Kratochvil
2012-07-27 8:21 ` Andrew Burgess
2012-07-27 14:06 ` Jan Kratochvil
2012-07-30 12:27 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vchbhgo9.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=aburgess@broadcom.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox