From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4257 invoked by alias); 25 Jul 2012 17:52:45 -0000 Received: (qmail 4246 invoked by uid 22791); 25 Jul 2012 17:52:44 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 25 Jul 2012 17:52:24 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6PHqOsR026834 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 25 Jul 2012 13:52:24 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q6PHqM0n029396 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 25 Jul 2012 13:52:23 -0400 From: Tom Tromey To: "Andrew Burgess" Cc: "gdb-patches\@sourceware.org" Subject: Re: Re-evaluate floating varobj as part of varobj_invalidate. References: <501025E0.30708@broadcom.com> Date: Wed, 25 Jul 2012 17:52:00 -0000 In-Reply-To: <501025E0.30708@broadcom.com> (Andrew Burgess's message of "Wed, 25 Jul 2012 17:59:12 +0100") Message-ID: <87vchbhgo9.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00562.txt.bz2 >>>>> "Andrew" == Andrew Burgess writes: Andrew> I have a bug & patch, but no great way to reproduce the issue as Andrew> it's a use of pointer after free issue, I suspect the recent-ish change to use -lmcheck by default will cause us to catch this bug in the test suite, at least on glibc-using systems. Andrew> The patch below simply removes the special case for floating Andrew> varobj objects from varobj_invalidate_iter, and causes them to Andrew> be re-evaluated or marked as invalid. Seems reasonable to me. Andrew> 2012-07-25 Andrew Burgess Andrew> * varobj.c (varobj_invalidate_iter): All varobj must be marked as Andrew> invalid or reevaluated to prevent prevent references to possibly Andrew> delete'd type objects being left in the varobj. Patch is ok. Tom