From: Tom Tromey <tromey@redhat.com>
To: Khoo Yit Phang <khooyp@cs.umd.edu>
Cc: Phil Muldoon <pmuldoon@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/4]: Make "python" start a standard Python prompt
Date: Thu, 26 Jul 2012 17:38:00 -0000 [thread overview]
Message-ID: <87vchae842.fsf@fleche.redhat.com> (raw)
In-Reply-To: <61B8FB86-D21F-4BA5-B86D-DF0ECF04C29D@cs.umd.edu> (Khoo Yit Phang's message of "Wed, 25 Jul 2012 17:07:17 -0400")
>>>>> "Yit" == Khoo Yit Phang <khooyp@cs.umd.edu> writes:
Yit> Here's the updated patch that creates a new command
Yit> "python-interactive", aliased to "pi", that starts a standard Python
Yit> REPL; and also aliases "python" to "py".
Looks pretty good to me.
I think it could use a NEWS entry.
Aside from doc review I have a couple of nits -- nothing serious.
Yit> + if (arg && *arg)
Yit> + {
Indentation looks wrong.
Yit> + err = PyRun_InteractiveLoop(instream, "<stdin>");
Space before open paren.
Yit> + if (err)
Yit> + {
Indentation.
The code parts are ok with those formatting fixes.
thanks,
Tom
next prev parent reply other threads:[~2012-07-26 17:38 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-16 20:47 Khoo Yit Phang
2012-07-24 21:19 ` Khoo Yit Phang
2012-07-25 6:45 ` Phil Muldoon
2012-07-25 16:18 ` Tom Tromey
2012-07-25 16:58 ` Khoo Yit Phang
2012-07-25 17:20 ` Matt Rice
2012-07-25 17:29 ` Khoo Yit Phang
2012-07-25 17:43 ` Tom Tromey
2012-07-25 17:55 ` Khoo Yit Phang
2012-07-25 17:59 ` Tom Tromey
2012-07-25 21:07 ` Khoo Yit Phang
2012-07-26 17:38 ` Tom Tromey [this message]
2012-07-26 17:52 ` Khoo Yit Phang
2012-07-26 18:06 ` Eli Zaretskii
2012-07-26 18:10 ` Khoo Yit Phang
2012-07-27 2:32 ` Khoo Yit Phang
2012-07-27 19:23 ` Tom Tromey
2012-07-28 6:53 ` Eli Zaretskii
2012-07-28 14:35 ` Khoo Yit Phang
2012-07-28 15:05 ` Eli Zaretskii
2012-07-28 15:14 ` Khoo Yit Phang
2012-07-31 22:04 ` Khoo Yit Phang
2012-08-01 15:46 ` Tom Tromey
2012-08-10 17:28 ` Khoo Yit Phang
2012-08-22 17:44 ` Khoo Yit Phang
2012-08-22 17:59 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vchae842.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=khooyp@cs.umd.edu \
--cc=pmuldoon@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox