From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3479 invoked by alias); 26 Jul 2012 17:38:12 -0000 Received: (qmail 3471 invoked by uid 22791); 26 Jul 2012 17:38:11 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 26 Jul 2012 17:37:53 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6QHbpBp007502 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 26 Jul 2012 13:37:51 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q6QHbn6F009239 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 26 Jul 2012 13:37:49 -0400 From: Tom Tromey To: Khoo Yit Phang Cc: Phil Muldoon , gdb-patches@sourceware.org Subject: Re: [PATCH 1/4]: Make "python" start a standard Python prompt References: <770F6E2B-70F5-4DF9-8E01-BD4F5FDC7AB1@cs.umd.edu> <500F95FB.5060904@redhat.com> <87zk6nizl6.fsf@fleche.redhat.com> <1C2FC4AD-E6FE-4857-9DE5-FDE5BE006E95@cs.umd.edu> <874novivob.fsf@fleche.redhat.com> <9DB9F174-129C-4C4A-9708-53A1D521251A@cs.umd.edu> <87mx2nhgch.fsf@fleche.redhat.com> <61B8FB86-D21F-4BA5-B86D-DF0ECF04C29D@cs.umd.edu> Date: Thu, 26 Jul 2012 17:38:00 -0000 In-Reply-To: <61B8FB86-D21F-4BA5-B86D-DF0ECF04C29D@cs.umd.edu> (Khoo Yit Phang's message of "Wed, 25 Jul 2012 17:07:17 -0400") Message-ID: <87vchae842.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00627.txt.bz2 >>>>> "Yit" == Khoo Yit Phang writes: Yit> Here's the updated patch that creates a new command Yit> "python-interactive", aliased to "pi", that starts a standard Python Yit> REPL; and also aliases "python" to "py". Looks pretty good to me. I think it could use a NEWS entry. Aside from doc review I have a couple of nits -- nothing serious. Yit> + if (arg && *arg) Yit> + { Indentation looks wrong. Yit> + err = PyRun_InteractiveLoop(instream, ""); Space before open paren. Yit> + if (err) Yit> + { Indentation. The code parts are ok with those formatting fixes. thanks, Tom