From: Tom Tromey <tromey@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org, Pedro Alves <palves@redhat.com>
Subject: Re: [RFA 3/3] Avoid duplicating text in sol-thread.c:info_cb
Date: Tue, 07 May 2013 14:27:00 -0000 [thread overview]
Message-ID: <87vc6uvpaf.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1367929532-4849-4-git-send-email-brobecker@adacore.com> (Joel Brobecker's message of "Tue, 7 May 2013 08:25:32 -0400")
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
Joel> * sol-thread.c (info_cb): Factorize the code a little.
Joel> Same as patch #2, I could probably self-approve, but there could be
Joel> merit in the current approach if the output was thought to one day
Joel> become different depending on some (future) factors...
I wouldn't worry about it.
It's trivial to change back if someone should need to.
Tom
next prev parent reply other threads:[~2013-05-07 14:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-30 17:09 FYI: copy/paste error in sol-thread.c ? Joel Brobecker
2013-05-02 15:22 ` Pedro Alves
2013-05-07 12:25 ` [RFA 2/3] Improve output of "maintenance info sol-threads" command Joel Brobecker
2013-05-07 14:26 ` Tom Tromey
2013-05-07 14:35 ` Pedro Alves
2013-05-08 6:27 ` Joel Brobecker
2013-05-08 6:28 ` Checked in: " Joel Brobecker
2013-05-07 12:25 ` FYI: copy/paste error in sol-thread.c ? Joel Brobecker
2013-05-07 12:25 ` [RFA 3/3] Avoid duplicating text in sol-thread.c:info_cb Joel Brobecker
2013-05-07 14:27 ` Tom Tromey [this message]
2013-05-08 6:28 ` Checked in: " Joel Brobecker
2013-05-07 12:25 ` [RFA/commit 1/3] ti.ti_pc vs ti.ti_startfunc copy-pasto " Joel Brobecker
2013-05-07 14:31 ` Pedro Alves
2013-05-08 6:28 ` Checked in: " Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vc6uvpaf.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox