From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sourceware.org
Cc: Pedro Alves <palves@redhat.com>, Joel Brobecker <brobecker@adacore.com>
Subject: [RFA 2/3] Improve output of "maintenance info sol-threads" command.
Date: Tue, 07 May 2013 12:25:00 -0000 [thread overview]
Message-ID: <1367929532-4849-3-git-send-email-brobecker@adacore.com> (raw)
In-Reply-To: <518284AF.5090802@redhat.com>
This patch does the following:
- Puts the startfunc and "Sleep func" info on the same line;
- Renames "Sleep func" into "sleepfunc" to be consistent with
"startfunc"
- Avoids the use of a '-' as a separate before the "sleepfunc"
output, because the '-' looks odd and out of place when the
"startfunc" field is not printed (ti.ti_startfunc is nul).
- Use a '=' instead of ':' and avoids the space between
the name of the value and its value, mostly to help group
the value with its name.
gdb/ChangeLog:
* sol-thread.c (info_cb): Rework the output of the "maintenance
info sol-threads" command a bit.
I could probably commit this one without approval, but someone else's
thoughts would be welcome, since this is a bit cosmetic.
---
gdb/sol-thread.c | 12 +++++-------
1 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/gdb/sol-thread.c b/gdb/sol-thread.c
index 2e76700..fb89723 100644
--- a/gdb/sol-thread.c
+++ b/gdb/sol-thread.c
@@ -1177,10 +1177,10 @@ info_cb (const td_thrhandle_t *th, void *s)
= lookup_minimal_symbol_by_pc (ti.ti_startfunc);
if (msym.minsym)
- printf_filtered (" startfunc: %s\n",
+ printf_filtered (" startfunc=%s",
SYMBOL_PRINT_NAME (msym.minsym));
else
- printf_filtered (" startfunc: %s\n",
+ printf_filtered (" startfunc=%s",
paddress (target_gdbarch (), ti.ti_startfunc));
}
@@ -1191,16 +1191,14 @@ info_cb (const td_thrhandle_t *th, void *s)
= lookup_minimal_symbol_by_pc (ti.ti_pc);
if (msym.minsym)
- printf_filtered (" - Sleep func: %s\n",
+ printf_filtered (" sleepfunc=%s",
SYMBOL_PRINT_NAME (msym.minsym));
else
- printf_filtered (" - Sleep func: %s\n",
+ printf_filtered (" sleepfunc=%s",
paddress (target_gdbarch (), ti.ti_pc));
}
- /* Wrap up line, if necessary. */
- if (ti.ti_state != TD_THR_SLEEP && ti.ti_startfunc == 0)
- printf_filtered ("\n"); /* don't you hate counting newlines? */
+ printf_filtered ("\n");
}
else
warning (_("info sol-thread: failed to get info for thread."));
--
1.7.0.4
next prev parent reply other threads:[~2013-05-07 12:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-30 17:09 FYI: copy/paste error in sol-thread.c ? Joel Brobecker
2013-05-02 15:22 ` Pedro Alves
2013-05-07 12:25 ` Joel Brobecker
2013-05-07 12:25 ` [RFA 3/3] Avoid duplicating text in sol-thread.c:info_cb Joel Brobecker
2013-05-07 14:27 ` Tom Tromey
2013-05-08 6:28 ` Checked in: " Joel Brobecker
2013-05-07 12:25 ` [RFA/commit 1/3] ti.ti_pc vs ti.ti_startfunc copy-pasto " Joel Brobecker
2013-05-07 14:31 ` Pedro Alves
2013-05-08 6:28 ` Checked in: " Joel Brobecker
2013-05-07 12:25 ` Joel Brobecker [this message]
2013-05-07 14:26 ` [RFA 2/3] Improve output of "maintenance info sol-threads" command Tom Tromey
2013-05-07 14:35 ` Pedro Alves
2013-05-08 6:27 ` Joel Brobecker
2013-05-08 6:28 ` Checked in: " Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1367929532-4849-3-git-send-email-brobecker@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox