Re: [PATCH 5/5] Fix for D demangling in GDB

[Tom Tromey <tromey@redhat.com>]

>>>>> "Iain" == Iain Buclaw <ibuclaw@gdcproject.org> writes:

Tom> It's also worth noting that with a bit more work you could push the D
Tom> demangler into libiberty (see ada_demangle there) and then get
Tom> demangling from "nm" and the other binutils.

Iain> That sounds like a good plan.  I'll keep a note to get round to do that.

Just FYI - I'm not sure if you know this or not, but libiberty is
canonically maintained in the GCC tree, so if you do this, it has to be
submitted there first.  Then it will be merged (either by me, or by
whoever else seems to be doing (semi-)automated merges) into
binutils-gdb.git.  So, it's a little bit of a pain.

Iain> This was copied from cp-demangle.exp.  I believe it is written that
Iain> way so that all demangle tests are ran, rather than stopping at the
Iain> first error?

The C++ one only works proc-by-proc.  If a test fails with a Tcl error
-- which btw isn't the same as just an ordinary failure, those don't
cause particular problems -- then it will run the subsequent procs.
Your test file only has a single proc; and anyway I'm guessing that code
in the C++ test is not useful anyway.  I think dropping it from your
patch is safe.

Tom