From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4637 invoked by alias); 10 Jan 2014 21:22:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4626 invoked by uid 89); 10 Jan 2014 21:22:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 10 Jan 2014 21:22:47 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0ALMjLD015761 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 10 Jan 2014 16:22:45 -0500 Received: from barimba (ovpn-113-85.phx2.redhat.com [10.3.113.85]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s0ALMisv022600 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 10 Jan 2014 16:22:44 -0500 From: Tom Tromey To: Iain Buclaw Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 5/5] Fix for D demangling in GDB References: <87zjn47ref.fsf@fleche.redhat.com> Date: Fri, 10 Jan 2014 21:22:00 -0000 In-Reply-To: (Iain Buclaw's message of "Fri, 10 Jan 2014 13:24:12 +0000") Message-ID: <87vbxr4jmk.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2014-01/txt/msg00298.txt.bz2 >>>>> "Iain" == Iain Buclaw writes: Tom> It's also worth noting that with a bit more work you could push the D Tom> demangler into libiberty (see ada_demangle there) and then get Tom> demangling from "nm" and the other binutils. Iain> That sounds like a good plan. I'll keep a note to get round to do that. Just FYI - I'm not sure if you know this or not, but libiberty is canonically maintained in the GCC tree, so if you do this, it has to be submitted there first. Then it will be merged (either by me, or by whoever else seems to be doing (semi-)automated merges) into binutils-gdb.git. So, it's a little bit of a pain. Iain> This was copied from cp-demangle.exp. I believe it is written that Iain> way so that all demangle tests are ran, rather than stopping at the Iain> first error? The C++ one only works proc-by-proc. If a test fails with a Tcl error -- which btw isn't the same as just an ordinary failure, those don't cause particular problems -- then it will run the subsequent procs. Your test file only has a single proc; and anyway I'm guessing that code in the C++ test is not useful anyway. I think dropping it from your patch is safe. Tom