Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <yao@codesourcery.com>
To: Doug Evans <dje@google.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/3] Check function is GC'ed
Date: Mon, 15 Sep 2014 08:06:00 -0000	[thread overview]
Message-ID: <87vbop2txg.fsf@codesourcery.com> (raw)
In-Reply-To: <87sikggadr.fsf@codesourcery.com> (Yao Qi's message of "Thu, 28	Aug 2014 18:46:08 +0800")

Yao Qi <yao@codesourcery.com> writes:

> In this patch, we choose 'lowpc' got in read_file_scope to check
> whether 'lowpc' is greater than zero.  If it isn't, address zero really
> means the function is GC'ed.  In this patch, we pass 'lowpc' in
> read_file_scope through handle_DW_AT_stmt_list and dwarf_decode_lines,
> and to dwarf_decode_lines_1 finally.
>
> This patch fixes the fail above. This patch also covers the path that
> partial symbol isn't used, which is tested by starting gdb with
> --readnow option.
>
> It is regression tested on x86-linux with
> target_board=dwarf4-gdb-index, and arm-none-eabi.  OK to apply?
>
> gdb:
>
> 2014-08-27  Yao Qi  <yao@codesourcery.com>
>
> 	* dwarf2read.c (dwarf_decode_lines): Update declaration.
> 	(handle_DW_AT_stmt_list): Add argument 'lowpc'.  Update
> 	comments.  Callers update.
> 	(dwarf_decode_lines): Likewise.
> 	(dwarf2_build_include_psymtabs): Likewise.
> 	(dwarf_decode_lines_1): Add argument 'lowpc'.  Update
> 	comments.  Skip the line table if  'lowpc' is greater than
> 	'address'.
>
> gdb/testsuite:
>
> 2014-08-27  Yao Qi  <yao@codesourcery.com>
>
> 	* gdb.base/break-on-linker-gcd-function.exp: Move test into new
> 	proc set_breakpoint_on_gcd_function.  Invoke
> 	set_breakpoint_on_gcd_function.  Restart GDB with --readnow and
> 	invoke set_breakpoint_on_gcd_function again.

Ping.  https://sourceware.org/ml/gdb-patches/2014-08/msg00595.html

-- 
Yao (齐尧)


  reply	other threads:[~2014-09-15  8:06 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-30  8:21 Revisit gdb/12528 for bare metal targets Yao Qi
2014-08-01 13:29 ` Yao Qi
2014-08-06  6:54 ` [PATCH 1/2] Remove pst from dwarf_decode_lines_1 Yao Qi
2014-08-06  6:54   ` [PATCH 2/2] Check function is GC'ed Yao Qi
2014-08-15  4:40     ` Doug Evans
2014-08-15  6:19       ` Yao Qi
2014-08-20 15:40     ` Pedro Alves
2014-08-13 12:01   ` [PATCH 1/2] Remove pst from dwarf_decode_lines_1 Yao Qi
2014-08-13 18:58     ` Doug Evans
2014-08-14 23:53       ` Yao Qi
2014-08-15  2:04         ` Yao Qi
2014-08-21  8:26 ` [PATCH 1/3] Check function is GC'ed Yao Qi
2014-08-21  8:26   ` [PATCH 3/3] Run dw2-var-zero-addr.exp with --readnow Yao Qi
2014-08-22 18:06     ` Doug Evans
2014-09-19  9:09       ` Yao Qi
2014-08-21  8:26   ` [PATCH 2/3] Check data is GC'ed Yao Qi
2014-08-22 18:02     ` Doug Evans
2014-08-29 13:32       ` Yao Qi
2014-08-22 17:40   ` [PATCH 1/3] Check function " Doug Evans
2014-08-28 10:50     ` Yao Qi
2014-09-15  8:06       ` Yao Qi [this message]
2014-09-15 18:53       ` Doug Evans
2014-09-16  2:40         ` Yao Qi
2014-09-18 16:42           ` Doug Evans
2014-09-19  9:08             ` Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vbop2txg.fsf@codesourcery.com \
    --to=yao@codesourcery.com \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox