From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29259 invoked by alias); 15 Sep 2014 08:06:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29247 invoked by uid 89); 15 Sep 2014 08:06:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 15 Sep 2014 08:06:22 +0000 Received: from svr-orw-fem-03.mgc.mentorg.com ([147.34.97.39]) by relay1.mentorg.com with esmtp id 1XTRIh-0002yu-Nn from Yao_Qi@mentor.com ; Mon, 15 Sep 2014 01:06:19 -0700 Received: from GreenOnly (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.3.181.6; Mon, 15 Sep 2014 01:06:18 -0700 From: Yao Qi To: Doug Evans CC: Subject: Re: [PATCH 1/3] Check function is GC'ed References: <53D8A264.1050103@codesourcery.com> <1408609338-17561-1-git-send-email-yao@codesourcery.com> <21495.32892.341399.802579@ruffy2.mtv.corp.google.com> <87sikggadr.fsf@codesourcery.com> Date: Mon, 15 Sep 2014 08:06:00 -0000 In-Reply-To: <87sikggadr.fsf@codesourcery.com> (Yao Qi's message of "Thu, 28 Aug 2014 18:46:08 +0800") Message-ID: <87vbop2txg.fsf@codesourcery.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-09/txt/msg00493.txt.bz2 Yao Qi writes: > In this patch, we choose 'lowpc' got in read_file_scope to check > whether 'lowpc' is greater than zero. If it isn't, address zero really > means the function is GC'ed. In this patch, we pass 'lowpc' in > read_file_scope through handle_DW_AT_stmt_list and dwarf_decode_lines, > and to dwarf_decode_lines_1 finally. > > This patch fixes the fail above. This patch also covers the path that > partial symbol isn't used, which is tested by starting gdb with > --readnow option. > > It is regression tested on x86-linux with > target_board=3Ddwarf4-gdb-index, and arm-none-eabi. OK to apply? > > gdb: > > 2014-08-27 Yao Qi > > * dwarf2read.c (dwarf_decode_lines): Update declaration. > (handle_DW_AT_stmt_list): Add argument 'lowpc'. Update > comments. Callers update. > (dwarf_decode_lines): Likewise. > (dwarf2_build_include_psymtabs): Likewise. > (dwarf_decode_lines_1): Add argument 'lowpc'. Update > comments. Skip the line table if 'lowpc' is greater than > 'address'. > > gdb/testsuite: > > 2014-08-27 Yao Qi > > * gdb.base/break-on-linker-gcd-function.exp: Move test into new > proc set_breakpoint_on_gcd_function. Invoke > set_breakpoint_on_gcd_function. Restart GDB with --readnow and > invoke set_breakpoint_on_gcd_function again. Ping. https://sourceware.org/ml/gdb-patches/2014-08/msg00595.html --=20 Yao (=E9=BD=90=E5=B0=A7)