Re: [PATCH] Merge dg-extract-results.{sh,py} from GCC upstream

[Sergio Durigan Junior <sergiodj@redhat.com>]

On Thursday, February 12 2015, Pedro Alves wrote:

> Wait, we may have gotten things backwards.
>
> Aren't we using the .sh version still?

Not if you have the Python version available.  From
dg-extract-results.sh:

  PROGNAME=dg-extract-results.sh

  # Try to use the python version if possible, since it tends to be faster.
  PYTHON_VER=`echo "$0" | sed 's/sh$/py/'`
  if test "$PYTHON_VER" != "$0" &&
     test -f "$PYTHON_VER" &&
     python -c 'import sys; sys.exit (0 if sys.version_info >= (2, 6) else 1)' \
       > /dev/null 2> /dev/null; then
    exec python $PYTHON_VER "$@"
  fi

> testsuite/Makefile.in:
> check-parallel:
> 	-rm -rf cache outputs temp
> 	$(MAKE) -k do-check-parallel; \
> 	$(SHELL) $(srcdir)/dg-extract-results.sh \
> 	  `find outputs -name gdb.sum -print` > gdb.sum; \
> 	$(SHELL) $(srcdir)/dg-extract-results.sh -L \
> 	  `find outputs -name gdb.log -print` > gdb.log
> 	@sed -n '/=== gdb Summary ===/,$$ p' gdb.sum
>
> Now I'm confused.  Is the issue then that patches to the .sh version
> that we pulled in with the last merge introduced the bad sorting?

I don't know if the new updates to dg-extract-results.sh caused some
regression, but AFAIR Jan stopped using the .py version (switching back
to the .sh one) and things got back to normal.

-- 
Sergio
GPG key ID: 0x65FC5E36
Please send encrypted e-mail if possible
http://sergiodj.net/