From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11575 invoked by alias); 12 Feb 2015 20:47:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11552 invoked by uid 89); 12 Feb 2015 20:47:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 12 Feb 2015 20:47:10 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1CKl9Jp019648 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 12 Feb 2015 15:47:09 -0500 Received: from localhost (dhcp-10-15-16-169.yyz.redhat.com [10.15.16.169]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t1CKl8sg014496 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Thu, 12 Feb 2015 15:47:09 -0500 From: Sergio Durigan Junior To: Pedro Alves Cc: GDB Patches Subject: Re: [PATCH] Merge dg-extract-results.{sh,py} from GCC upstream References: <1418686405-29922-1-git-send-email-sergiodj@redhat.com> <54DD0C8F.6050303@redhat.com> <87zj8idg6r.fsf@redhat.com> <54DD0F3D.6010809@redhat.com> X-URL: http://blog.sergiodj.net Date: Thu, 12 Feb 2015 20:47:00 -0000 In-Reply-To: <54DD0F3D.6010809@redhat.com> (Pedro Alves's message of "Thu, 12 Feb 2015 20:38:21 +0000") Message-ID: <87vbj6dfhv.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2015-02/txt/msg00337.txt.bz2 On Thursday, February 12 2015, Pedro Alves wrote: > Wait, we may have gotten things backwards. > > Aren't we using the .sh version still? Not if you have the Python version available. From dg-extract-results.sh: PROGNAME=dg-extract-results.sh # Try to use the python version if possible, since it tends to be faster. PYTHON_VER=`echo "$0" | sed 's/sh$/py/'` if test "$PYTHON_VER" != "$0" && test -f "$PYTHON_VER" && python -c 'import sys; sys.exit (0 if sys.version_info >= (2, 6) else 1)' \ > /dev/null 2> /dev/null; then exec python $PYTHON_VER "$@" fi > testsuite/Makefile.in: > check-parallel: > -rm -rf cache outputs temp > $(MAKE) -k do-check-parallel; \ > $(SHELL) $(srcdir)/dg-extract-results.sh \ > `find outputs -name gdb.sum -print` > gdb.sum; \ > $(SHELL) $(srcdir)/dg-extract-results.sh -L \ > `find outputs -name gdb.log -print` > gdb.log > @sed -n '/=== gdb Summary ===/,$$ p' gdb.sum > > Now I'm confused. Is the issue then that patches to the .sh version > that we pulled in with the last merge introduced the bad sorting? I don't know if the new updates to dg-extract-results.sh caused some regression, but AFAIR Jan stopped using the .py version (switching back to the .sh one) and things got back to normal. -- Sergio GPG key ID: 0x65FC5E36 Please send encrypted e-mail if possible http://sergiodj.net/