From: Tom Tromey <tom@tromey.com>
To: Tom Tromey <tom@tromey.com>
Cc: Simon Marchi <simon.marchi@polymtl.ca>, gdb-patches@sourceware.org
Subject: Re: [RFA] Fix gdb snapshots
Date: Wed, 29 Nov 2017 17:04:00 -0000 [thread overview]
Message-ID: <87vaht6mov.fsf@tromey.com> (raw)
In-Reply-To: <87zi756mw4.fsf@tromey.com> (Tom Tromey's message of "Wed, 29 Nov 2017 10:00:11 -0700")
Tom> Perhaps rmdir||true will be more to your liking.
How's this?
Tom
commit ea7e34a8e4a79231ea952f711d02729021cbabd0
Author: Tom Tromey <tom@tromey.com>
Date: Wed Nov 29 09:27:40 2017 -0700
Fix gdb snapshots
Joel pointed out that gdb snapshots were broken by my Makefile patch
series. The bug is that rmdir in distclean was failing, because the
directories in question did not exist. This fixes the problem by
ignoring errors from rmdir.
Tested using "src-release.sh gdb".
2017-11-29 Tom Tromey <tom@tromey.com>
* Makefile.in (distclean): Handle the case where rmdir fails.
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index ebb969998c..dbea503d02 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2017-11-29 Tom Tromey <tom@tromey.com>
+
+ * Makefile.in (distclean): Handle the case where rmdir fails.
+
2017-11-27 Tom Tromey <tom@tromey.com>
* Makefile.in (REMOTE_OBS): Remove.
diff --git a/gdb/Makefile.in b/gdb/Makefile.in
index 6e16bc6682..1ecd5a76b3 100644
--- a/gdb/Makefile.in
+++ b/gdb/Makefile.in
@@ -1995,7 +1995,7 @@ distclean: clean
rm -f Makefile
rm -rf $(DEPDIR)
for i in $(CONFIG_SRC_SUBDIR); do \
- rmdir $$i/$(DEPDIR); \
+ rm -rf $$i/$(DEPDIR) || true; \
done
maintainer-clean: local-maintainer-clean do-maintainer-clean distclean
next prev parent reply other threads:[~2017-11-29 17:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-29 16:32 Tom Tromey
2017-11-29 16:42 ` Simon Marchi
2017-11-29 17:00 ` Tom Tromey
2017-11-29 17:04 ` Tom Tromey [this message]
2017-11-29 17:27 ` Tom Tromey
2017-11-29 17:38 ` Simon Marchi
2017-11-29 18:53 ` Tom Tromey
2017-11-29 17:06 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vaht6mov.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox