From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>
Subject: [RFA] Fix gdb snapshots
Date: Wed, 29 Nov 2017 16:32:00 -0000 [thread overview]
Message-ID: <20171129163158.18968-1-tom@tromey.com> (raw)
Joel pointed out that gdb snapshots were broken by my Makefile patch
series. The bug is that rmdir in distclean was failing, because the
directories in question did not exist. The simplest fix was to just use
"rm -rf", which won't fail if the directory is missing.
Tested using "src-release.sh gdb".
2017-11-29 Tom Tromey <tom@tromey.com>
* Makefile.in (distclean): Use "rm -rf", not "rmdir".
---
gdb/ChangeLog | 4 ++++
gdb/Makefile.in | 4 +++-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index ebb969998c..7532016499 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2017-11-29 Tom Tromey <tom@tromey.com>
+
+ * Makefile.in (distclean): Use "rm -rf", not "rmdir".
+
2017-11-27 Tom Tromey <tom@tromey.com>
* Makefile.in (REMOTE_OBS): Remove.
diff --git a/gdb/Makefile.in b/gdb/Makefile.in
index 6e16bc6682..39f90bad9f 100644
--- a/gdb/Makefile.in
+++ b/gdb/Makefile.in
@@ -1995,7 +1995,9 @@ distclean: clean
rm -f Makefile
rm -rf $(DEPDIR)
for i in $(CONFIG_SRC_SUBDIR); do \
- rmdir $$i/$(DEPDIR); \
+ # Use rm -rf, not rmdir, to avoid errors when the \
+ # directory does not exist. \
+ rm -rf $$i/$(DEPDIR); \
done
maintainer-clean: local-maintainer-clean do-maintainer-clean distclean
--
2.13.6
next reply other threads:[~2017-11-29 16:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-29 16:32 Tom Tromey [this message]
2017-11-29 16:42 ` Simon Marchi
2017-11-29 17:00 ` Tom Tromey
2017-11-29 17:04 ` Tom Tromey
2017-11-29 17:27 ` Tom Tromey
2017-11-29 17:38 ` Simon Marchi
2017-11-29 18:53 ` Tom Tromey
2017-11-29 17:06 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171129163158.18968-1-tom@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox