Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/mi: New commands to catch C++ exceptions
Date: Thu, 09 May 2019 21:50:00 -0000	[thread overview]
Message-ID: <87v9yjcn67.fsf@tromey.com> (raw)
In-Reply-To: <20190509000500.20536-1-andrew.burgess@embecosm.com> (Andrew	Burgess's message of "Thu, 9 May 2019 01:05:00 +0100")

>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:

Andrew> Adds some MI commands to catch C++ exceptions.  These are
Andrew> -catch-throw, -catch-rethrow, and -catch-catch, these all correspond
Andrew> to the CLI commands 'catch throw', 'catch rethrow', and 'catch catch'.

Thanks for the patch.

I read through this and it all seems good to me (of course Eli will have
to approve the docs).

I had one tiny nit.

Andrew> +void catch_exception_event (enum exception_event_kind ex_event,
Andrew> +			    const char *regex, bool tempflag, int from_tty);

The style in breakpoint.h seems to be to use "extern void ...".

Tom


  reply	other threads:[~2019-05-09 21:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-09  0:05 Andrew Burgess
2019-05-09 21:50 ` Tom Tromey [this message]
2019-05-10  7:01 ` Eli Zaretskii
2019-05-11 23:46 ` [PATCHv2] " Andrew Burgess
2019-05-12  4:09   ` Eli Zaretskii
2019-06-15 22:34   ` Andrew Burgess
2019-06-16 13:14     ` Tom de Vries
2019-06-16 15:30       ` Andrew Burgess
2019-06-16 21:45         ` Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v9yjcn67.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=andrew.burgess@embecosm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox