From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 46244 invoked by alias); 9 May 2019 21:50:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 46236 invoked by uid 89); 9 May 2019 21:50:44 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=approve, HX-Languages-Length:694 X-HELO: gateway33.websitewelcome.com Received: from gateway33.websitewelcome.com (HELO gateway33.websitewelcome.com) (192.185.145.190) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 09 May 2019 21:50:42 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway33.websitewelcome.com (Postfix) with ESMTP id 906B9820B7 for ; Thu, 9 May 2019 16:50:41 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id Oqw5hxKw14FKpOqw5hMGFy; Thu, 09 May 2019 16:50:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Rjs+ohNZOQyxFLsecbHd2UZoGkk74x5GLI2Rxx5zSbk=; b=Im/86fmxG+bTw/Poa/+pSjUwAt mJIOjaDpxEsiW5xyhcAOLEvPTvfcz+2fZVecthbN2YrC+UnbNnjLTUjrieyI4Z5/eHRStLQYauh2H b7Q64MPnoth/NfG7/SbkfOKEY; Received: from 97-122-168-123.hlrn.qwest.net ([97.122.168.123]:57938 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1hOqw5-002Y73-BF; Thu, 09 May 2019 16:50:41 -0500 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/mi: New commands to catch C++ exceptions References: <20190509000500.20536-1-andrew.burgess@embecosm.com> Date: Thu, 09 May 2019 21:50:00 -0000 In-Reply-To: <20190509000500.20536-1-andrew.burgess@embecosm.com> (Andrew Burgess's message of "Thu, 9 May 2019 01:05:00 +0100") Message-ID: <87v9yjcn67.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-05/txt/msg00234.txt.bz2 >>>>> "Andrew" == Andrew Burgess writes: Andrew> Adds some MI commands to catch C++ exceptions. These are Andrew> -catch-throw, -catch-rethrow, and -catch-catch, these all correspond Andrew> to the CLI commands 'catch throw', 'catch rethrow', and 'catch catch'. Thanks for the patch. I read through this and it all seems good to me (of course Eli will have to approve the docs). I had one tiny nit. Andrew> +void catch_exception_event (enum exception_event_kind ex_event, Andrew> + const char *regex, bool tempflag, int from_tty); The style in breakpoint.h seems to be to use "extern void ...". Tom