From: Tom Tromey <tromey@adacore.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Add "style" proc to the test suite
Date: Tue, 14 May 2019 16:31:00 -0000 [thread overview]
Message-ID: <87v9yd9ewl.fsf@tromey.com> (raw)
In-Reply-To: <20190514145854.GM2568@embecosm.com> (Andrew Burgess's message of "Tue, 14 May 2019 15:58:55 +0100")
>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:
>> + set sofile [style "\[^\033\]+" file]
Andrew> I wonder if there's a nice way to get rid of the \033 here? Two
Andrew> thoughts I had was a different proc so we could maybe write this:
Andrew> set sofile [styled-string file]
Andrew> Alternatively, I wondered if we could special case this:
Andrew> set sofile [styled ".*" file]
Andrew> So that if we pass exactly ".*" it is changed into "\[^\033\]+" inside
Andrew> the style proc.
Andrew> Just thought it might be nice to try and remove more of the escape
Andrew> sequences.
Another idea is to just make it non-greedy with
set sofile [style ".*?" file]
Tom
next prev parent reply other threads:[~2019-05-14 16:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 14:05 Tom Tromey
2019-05-14 14:59 ` Andrew Burgess
2019-05-14 16:31 ` Tom Tromey [this message]
2019-05-22 17:59 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9yd9ewl.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox