From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 90882 invoked by alias); 14 May 2019 16:31:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 90856 invoked by uid 89); 14 May 2019 16:31:11 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-10.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:739 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 14 May 2019 16:31:09 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id DBA8D117889; Tue, 14 May 2019 12:31:07 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id if9V0T6Zwlj9; Tue, 14 May 2019 12:31:07 -0400 (EDT) Received: from murgatroyd (97-122-168-123.hlrn.qwest.net [97.122.168.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPSA id 612BE11787E; Tue, 14 May 2019 12:31:07 -0400 (EDT) From: Tom Tromey To: Andrew Burgess Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Add "style" proc to the test suite References: <20190514140536.11845-1-tromey@adacore.com> <20190514145854.GM2568@embecosm.com> Date: Tue, 14 May 2019 16:31:00 -0000 In-Reply-To: <20190514145854.GM2568@embecosm.com> (Andrew Burgess's message of "Tue, 14 May 2019 15:58:55 +0100") Message-ID: <87v9yd9ewl.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-05/txt/msg00334.txt.bz2 >>>>> "Andrew" == Andrew Burgess writes: >> + set sofile [style "\[^\033\]+" file] Andrew> I wonder if there's a nice way to get rid of the \033 here? Two Andrew> thoughts I had was a different proc so we could maybe write this: Andrew> set sofile [styled-string file] Andrew> Alternatively, I wondered if we could special case this: Andrew> set sofile [styled ".*" file] Andrew> So that if we pass exactly ".*" it is changed into "\[^\033\]+" inside Andrew> the style proc. Andrew> Just thought it might be nice to try and remove more of the escape Andrew> sequences. Another idea is to just make it non-greedy with set sofile [style ".*?" file] Tom