From: Yoshinori Sato <ysato@users.sourceforge.jp>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v3] Convert the RX target to make use of target descriptions.
Date: Fri, 23 Aug 2019 13:41:00 -0000 [thread overview]
Message-ID: <87v9uoj8x7.wl-ysato@users.sourceforge.jp> (raw)
In-Reply-To: <20190822095652.340db6e6@f29-4.lan>
On Fri, 23 Aug 2019 01:56:52 +0900,
Kevin Buettner wrote:
>
> On Thu, 22 Aug 2019 23:30:26 +0900
> Yoshinori Sato <ysato@users.sourceforge.jp> wrote:
>
> > gdb/ChangeLog
> >
> > 2019-08-22 Yoshinori Sato <ysato@users.sourceforge.jp>
> >
> > * gdb/rx-tdep.c (rx_register_names): New.
> > (rx_register_name): delete.
> > (rx_psw_type): delete.
> > (rx_fpsw_type): delete.
> > (rx_register_type): delete.
> > (rx_gdbarch_init): Convert target-descriptions.
> > (_initialize_rx_tdep): Add initialize_tdesc_rx.
> > * gdb/features/Makefile: Add rx.xml.
> > * gdb/features/rx.xml: New.
> > * gdb/features/rx.c: Likewise.
> > * gdb/NEWS: Mention target description support.
>
> One small nit - for gdb/features/rx.c, I'd prefer to see a ChangeLog
> comment saying that it's been generated. I.e.
>
> * gdb/features/rx.c: Generate.
>
> The rest looks good to me. If there are no other suggestions from
> someone else, go ahead and commit it with that small tweak.
>
> Kevin
OK.
This log will be fixed when I commit.
--
Yosinori Sato
next prev parent reply other threads:[~2019-08-23 13:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-22 14:31 Yoshinori Sato
2019-08-22 14:36 ` Eli Zaretskii
2019-08-22 16:56 ` Kevin Buettner
2019-08-23 13:41 ` Yoshinori Sato [this message]
2019-08-23 15:01 ` Simon Marchi
2019-08-24 13:41 ` Yoshinori Sato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9uoj8x7.wl-ysato@users.sourceforge.jp \
--to=ysato@users.sourceforge.jp \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox