From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 91322 invoked by alias); 23 Aug 2019 13:41:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 91314 invoked by uid 89); 23 Aug 2019 13:41:48 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_SOFTFAIL autolearn=no version=3.3.1 spammy=H*UA:6.0, H*u:6.0, HX-Languages-Length:1099, HX-Spam-Relays-External:ESMTPA X-HELO: mail02.asahi-net.or.jp Received: from mail02.asahi-net.or.jp (HELO mail02.asahi-net.or.jp) (202.224.55.14) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 23 Aug 2019 13:41:47 +0000 Received: from h61-195-96-97.vps.ablenet.jp (h61-195-96-97.ablenetvps.ne.jp [61.195.96.97]) (Authenticated sender: PQ4Y-STU) by mail02.asahi-net.or.jp (Postfix) with ESMTPA id 27FF65BD9B; Fri, 23 Aug 2019 22:41:42 +0900 (JST) Received: from yo-satoh-debian.ysato.ml (ZM005235.ppp.dion.ne.jp [222.8.5.235]) by h61-195-96-97.vps.ablenet.jp (Postfix) with ESMTPSA id ED0AE240086; Fri, 23 Aug 2019 22:41:40 +0900 (JST) Date: Fri, 23 Aug 2019 13:41:00 -0000 Message-ID: <87v9uoj8x7.wl-ysato@users.sourceforge.jp> From: Yoshinori Sato To: Kevin Buettner Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v3] Convert the RX target to make use of target descriptions. In-Reply-To: <20190822095652.340db6e6@f29-4.lan> References: <20190822143026.82014-1-ysato@users.sourceforge.jp> <20190822095652.340db6e6@f29-4.lan> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/25.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-IsSubscribed: yes X-SW-Source: 2019-08/txt/msg00545.txt.bz2 On Fri, 23 Aug 2019 01:56:52 +0900, Kevin Buettner wrote: > > On Thu, 22 Aug 2019 23:30:26 +0900 > Yoshinori Sato wrote: > > > gdb/ChangeLog > > > > 2019-08-22 Yoshinori Sato > > > > * gdb/rx-tdep.c (rx_register_names): New. > > (rx_register_name): delete. > > (rx_psw_type): delete. > > (rx_fpsw_type): delete. > > (rx_register_type): delete. > > (rx_gdbarch_init): Convert target-descriptions. > > (_initialize_rx_tdep): Add initialize_tdesc_rx. > > * gdb/features/Makefile: Add rx.xml. > > * gdb/features/rx.xml: New. > > * gdb/features/rx.c: Likewise. > > * gdb/NEWS: Mention target description support. > > One small nit - for gdb/features/rx.c, I'd prefer to see a ChangeLog > comment saying that it's been generated. I.e. > > * gdb/features/rx.c: Generate. > > The rest looks good to me. If there are no other suggestions from > someone else, go ahead and commit it with that small tweak. > > Kevin OK. This log will be fixed when I commit. -- Yosinori Sato