Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom Tromey <tom@tromey.com>
Subject: Re: [PATCH][gdb/testsuite] Reimplement gdb.gdb/python-interrupts.exp as unittest
Date: Tue, 19 Oct 2021 12:10:52 -0600	[thread overview]
Message-ID: <87v91sx4ur.fsf@tromey.com> (raw)
In-Reply-To: <d767624c-250e-9777-ee07-e7160a68c0bb@suse.de> (Tom de Vries via Gdb-patches's message of "Wed, 22 Sep 2021 12:17:46 +0200")

>>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:

>> +#if GDB_SELF_TEST
>> +  if (selftests::hook_set_active_ext_lang)
>> +    selftests::hook_set_active_ext_lang ();
>> +#endif

Tom> In particular, I'd like feedback on whether this is acceptable.

Tom> F.i., I could do instead the less intrusive (but also less flexible):

Either way is fine by me.  It's clearly code just for testing purposes,
so, for me at least, I don't mind if it's too flexible or whatever.

Tom> Perhaps this could be handled using a
Tom> DEVEL_GDB_SELF_TEST, which is disabled in release branches independent
Tom> of --enable-unit-tests?

I don't really understand what you meant by this.
Do you mean having some way to disable some subset of the self-tests?
If so, I think it's fine to just have them all around.

Tom

  parent reply	other threads:[~2021-10-19 18:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-11 12:02 Tom de Vries via Gdb-patches
2021-09-22 10:17 ` Tom de Vries via Gdb-patches
2021-10-07 14:36   ` [PING][PATCH][gdb/testsuite] " Tom de Vries via Gdb-patches
2021-10-19 18:10   ` Tom Tromey [this message]
2021-10-19 22:00     ` [PATCH][gdb/testsuite] " Tom de Vries via Gdb-patches
2021-10-19 18:09 ` Tom Tromey
2021-10-19 21:56   ` Tom de Vries via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v91sx4ur.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox